Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Aleksey Shipilev
On Tue, 27 May 2025 07:45:35 GMT, Alan Bateman wrote: > Does SonarCloud scan source code or class files? I'm wondering if there is > anything to feedback to them on this report. I think both. But as I said, I misunderstood the report: it tells me we are using a boxed `Boolean`, likely unnecess

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Alan Bateman
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using > `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` > was made in [JDK-8356080](https://bugs.openjdk

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread Aleksey Shipilev
On Mon, 26 May 2025 19:01:35 GMT, Chen Liang wrote: > How is this an allocation? I examined `javap -c -p -v > java.util.ReverseOrderListView` and confirmed this compiles to > `Boolean.valueOf` in class files, which involves no new allocation. Yeah, I brain-fogged a little here. Still, it makes

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-27 Thread ExE Boss
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating > and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> > `Boolean` was made in > [JDK-8356080](ht

Re: RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-26 Thread Chen Liang
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote: > SonarCloud complains that since > [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating > and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> > `Boolean` was made in > [JDK-8356080](ht

RFR: 8357798: ReverseOrderListView allocates Boolean boxes

2025-05-26 Thread Aleksey Shipilev
SonarCloud complains that since [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean` was made in [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) to allow `@Stable` folding