Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init [v2]

2025-05-27 Thread Aleksey Shipilev
On Mon, 26 May 2025 17:17:30 GMT, Aleksey Shipilev wrote: >> SonarCloud complains `ST_NEW` constant is not used. Looks to me the >> constructor implicitly relies on default value for `state`. It would be >> cleaner to initialize it explicitly >> >> Additional testing: >> - [x] Linux x86_64 se

Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init [v2]

2025-05-26 Thread Aleksey Shipilev
> SonarCloud complains `ST_NEW` constant is not used. Looks to me the > constructor implicitly relies on default value for `state`. It would be > cleaner to initialize it explicitly > > Additional testing: > - [x] Linux x86_64 server fastdebug, `java/util/concurrent` Aleksey Shipilev has updat

Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init [v2]

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 17:17:30 GMT, Aleksey Shipilev wrote: >> SonarCloud complains `ST_NEW` constant is not used. Looks to me the >> constructor implicitly relies on default value for `state`. It would be >> cleaner to initialize it explicitly >> >> Additional testing: >> - [x] Linux x86_64 se

Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init [v2]

2025-05-26 Thread Aleksey Shipilev
On Mon, 26 May 2025 16:46:49 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move to the end > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScopeImpl.java > line 70: > >>

Re: RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init

2025-05-26 Thread Alan Bateman
On Mon, 26 May 2025 16:37:01 GMT, Aleksey Shipilev wrote: > SonarCloud complains `ST_NEW` constant is not used. Looks to me the > constructor implicitly relies on default value for `state`. It would be > cleaner to initialize it explicitly > > Additional testing: > - [x] Linux x86_64 server f

RFR: 8357797: Use StructuredTaskScopeImpl.ST_NEW for state init

2025-05-26 Thread Aleksey Shipilev
SonarCloud complains `ST_NEW` constant is not used. Looks to me the constructor implicitly relies on default value for `state`. It would be cleaner to initialize it explicitly Additional testing: - [x] Linux x86_64 server fastdebug, `java/util/concurrent` - Commit messages: - Fix