Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-20 Thread Shaojin Wen
On Tue, 20 May 2025 15:53:34 GMT, Jaikiran Pai wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> warning > > src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 348: > >> 346: */ >> 347: pu

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-20 Thread Jaikiran Pai
On Fri, 16 May 2025 16:10:29 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with one additional > commit sinc

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-19 Thread Roger Riggs
On Fri, 16 May 2025 16:10:29 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with one additional > commit sinc

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-19 Thread Volkan Yazici
On Fri, 16 May 2025 16:10:29 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with one additional > commit sinc

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-16 Thread Chen Liang
On Fri, 16 May 2025 16:10:29 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with one additional > commit sinc

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v4]

2025-05-16 Thread Shaojin Wen
> Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: warning - Changes: - al

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v3]

2025-05-16 Thread Shaojin Wen
> Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. Shaojin Wen has updated the pull request incrementally with seven additional commits since the last revision: - Update src/java.base/share/classes/

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v2]

2025-05-16 Thread Chen Liang
On Fri, 16 May 2025 09:45:43 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with two additional > commits sin

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v2]

2025-05-16 Thread Volkan Yazici
On Fri, 16 May 2025 09:45:43 GMT, Shaojin Wen wrote: >> Similar to PR #24982 >> Document preconditions on certain DecimalDigits methods that use operations >> either unsafe and/or without range checks. > > Shaojin Wen has updated the pull request incrementally with two additional > commits sin

Re: RFR: 8357063: Document preconditions for DecimalDigits methods [v2]

2025-05-16 Thread Shaojin Wen
> Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision: - assert - document add warnings

Re: RFR: 8357063: Document preconditions for DecimalDigits methods

2025-05-16 Thread Volkan Yazici
On Thu, 15 May 2025 06:24:44 GMT, Shaojin Wen wrote: > Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 297: > 295: */ > 29

Re: RFR: 8357063: Document preconditions for DecimalDigits methods

2025-05-16 Thread Raffaello Giulietti
On Thu, 15 May 2025 06:24:44 GMT, Shaojin Wen wrote: > Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. The renaming is nice and useful. But #24982, in addition to renaming, emphasizes the expectatio

Re: RFR: 8357063: Document preconditions for DecimalDigits methods

2025-05-15 Thread Shaojin Wen
On Thu, 15 May 2025 18:12:28 GMT, Raffaello Giulietti wrote: > @wenshao I understand this is a kind of followup of #24982, but why this > title? It seems just renaming some methods with more speaking names. Yes, it is just a renaming of some methods, the title is followup #24982, does the sam

RFR: 8357063: Document preconditions for DecimalDigits methods

2025-05-15 Thread Shaojin Wen
Similar to PR #24982 Document preconditions on certain DecimalDigits methods that use operations either unsafe and/or without range checks. - Commit messages: - Document preconditions for DecimalDigits methods Changes: https://git.openjdk.org/jdk/pull/25246/files Webrev: https:/

Re: RFR: 8357063: Document preconditions for DecimalDigits methods

2025-05-15 Thread Raffaello Giulietti
On Thu, 15 May 2025 06:24:44 GMT, Shaojin Wen wrote: > Similar to PR #24982 > Document preconditions on certain DecimalDigits methods that use operations > either unsafe and/or without range checks. @wenshao I understand this is a kind of followup of #24982, but why this title? It seems just