Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-21 Thread Jiangli Zhou
On Wed, 21 May 2025 18:46:25 GMT, Roger Riggs wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year in >> test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java. > > lgtm @RogerRiggs Tha

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-21 Thread Roger Riggs
On Wed, 14 May 2025 15:44:08 GMT, Jiangli Zhou wrote: >> Please review this PR for skipping >> jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the >> context from https://bugs.openjdk.org/browse/JDK-8356904 description: >> >> jdk/test/lib/process/TestNativeProcessBuild

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-21 Thread Jiangli Zhou
On Wed, 14 May 2025 15:44:08 GMT, Jiangli Zhou wrote: >> Please review this PR for skipping >> jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the >> context from https://bugs.openjdk.org/browse/JDK-8356904 description: >> >> jdk/test/lib/process/TestNativeProcessBuild

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-19 Thread Jiangli Zhou
On Tue, 20 May 2025 00:49:28 GMT, Henry Jen wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year in >> test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java. > > Marked as reviewed by h

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-19 Thread Henry Jen
On Mon, 19 May 2025 19:56:52 GMT, Jiangli Zhou wrote: >> @sendaoYan Please let me know if you have any additional review comments, >> thanks. >> >> Also looking for a 'R'eviewer for reviewing. Thanks! > > A friendly ping LGTM. - PR Review Comment: https://git.openjdk.org/jdk/pull

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-19 Thread Henry Jen
On Wed, 14 May 2025 15:44:08 GMT, Jiangli Zhou wrote: >> Please review this PR for skipping >> jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the >> context from https://bugs.openjdk.org/browse/JDK-8356904 description: >> >> jdk/test/lib/process/TestNativeProcessBuild

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-19 Thread Jiangli Zhou
On Thu, 15 May 2025 17:15:20 GMT, Jiangli Zhou wrote: >> test/lib-test/TEST.ROOT line 31: >> >>> 29: keys=randomness >>> 30: >>> 31: # Minimum jtreg version >> >> Shoule we update the copyright year for file TestNativeProcessBuilder.java > > @sendaoYan Please let me know if you have any additi

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-15 Thread Jiangli Zhou
On Wed, 14 May 2025 13:21:37 GMT, SendaoYan wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year in >> test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java. > > test/lib-test/TEST.ROOT

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-14 Thread Jiangli Zhou
On Wed, 14 May 2025 13:21:37 GMT, SendaoYan wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year in >> test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java. > > test/lib-test/TEST.ROOT

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk [v2]

2025-05-14 Thread Jiangli Zhou
> Please review this PR for skipping > jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the > context from https://bugs.openjdk.org/browse/JDK-8356904 description: > > jdk/test/lib/process/TestNativeProcessBuilder.java (in lib-test/tier1) uses a > native test launcher ex

Re: RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk

2025-05-14 Thread SendaoYan
On Tue, 13 May 2025 21:28:00 GMT, Jiangli Zhou wrote: > Please review this PR for skipping > jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the > context from https://bugs.openjdk.org/browse/JDK-8356904 description: > > jdk/test/lib/process/TestNativeProcessBuilder.ja

RFR: 8356904: Skip jdk/test/lib/process/TestNativeProcessBuilder on static-jdk

2025-05-13 Thread Jiangli Zhou
Please review this PR for skipping jdk/test/lib/process/TestNativeProcessBuilder on static-jdk. Duplicating the context from https://bugs.openjdk.org/browse/JDK-8356904 description: jdk/test/lib/process/TestNativeProcessBuilder.java (in lib-test/tier1) uses a native test launcher executable, ex