Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v4]

2025-05-15 Thread Raffaello Giulietti
On Wed, 14 May 2025 14:39:37 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Johannes Graham has updated the pull reque

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v4]

2025-05-15 Thread duke
On Wed, 14 May 2025 14:39:37 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Johannes Graham has updated the pull reque

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-15 Thread Johannes Graham
On Mon, 12 May 2025 02:06:23 GMT, Chen Liang wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Sorry, didn't see your core-libs-dev mail. Crea

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-14 Thread Raffaello Giulietti
On Sun, 11 May 2025 16:32:02 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > On Aarch64 M4: > > Benchmark

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v2]

2025-05-14 Thread Raffaello Giulietti
On Wed, 14 May 2025 13:33:32 GMT, Johannes Graham wrote: >> test/jdk/java/math/BigDecimal/ValueOfDouble.java line 41: >> >>> 39: >>> 40: public class ValueOfDouble { >>> 41: private static final String DIGITS = "1234567899123456789"; // >>> Enough digits to fill a long >> >> Suggestion: >

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v3]

2025-05-14 Thread Raffaello Giulietti
On Wed, 14 May 2025 13:47:11 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Johannes Graham has updated the pull reque

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v4]

2025-05-14 Thread Johannes Graham
> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. Johannes Graham has updated the pull request incrementally with three additional commits since the last re

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v3]

2025-05-14 Thread Johannes Graham
> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. Johannes Graham has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v2]

2025-05-14 Thread Johannes Graham
On Wed, 14 May 2025 09:55:35 GMT, Raffaello Giulietti wrote: >> Johannes Graham has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix code tag in javadoc > > src/java.base/share/classes/java/math/BigDecimal.java line 1408: > >> 1406:

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v2]

2025-05-14 Thread Raffaello Giulietti
On Tue, 13 May 2025 13:03:42 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > Johannes Graham has updated the pull reque

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double) [v2]

2025-05-13 Thread Johannes Graham
> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. Johannes Graham has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Joe Darcy
On Sun, 11 May 2025 16:22:11 GMT, Johannes Graham wrote: > Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. src/java.base/share/classes/jdk/internal/math/Fo

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Johannes Graham
On Sun, 11 May 2025 18:45:47 GMT, Chen Liang wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > test/jdk/java/math/BigDecimal/ValueOfDouble.jav

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Raffaello Giulietti
On Sun, 11 May 2025 16:22:11 GMT, Johannes Graham wrote: > Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. macOS 15.4.1 / M1 Pro / 32 GiB RAM BigDecimals.

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Raffaello Giulietti
On Sun, 11 May 2025 16:32:02 GMT, Johannes Graham wrote: >> Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead >> of converting to decimal string and then parsing it. This results in an >> approximate 6x improvement for me. > > On Aarch64 M4: > > Benchmark

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Johannes Graham
On Sun, 11 May 2025 16:22:11 GMT, Johannes Graham wrote: > Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. On Aarch64 M4: Benchmark

RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Johannes Graham
Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead of converting to decimal string and then parsing it. This results in an approximate 6x improvement for me. - Commit messages: - add bug number to test, fix typo - wait for real bug number to set it in head

Re: RFR: 8356709: Avoid redundant String formatting in BigDecimal.valueOf(double)

2025-05-12 Thread Chen Liang
On Sun, 11 May 2025 16:22:11 GMT, Johannes Graham wrote: > Optimize `BigDecimal.valueOf(double)` by using `FormattedFPDecimal` instead > of converting to decimal string and then parsing it. This results in an > approximate 6x improvement for me. Thanks for this improvement! Looks great! Sorry