Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v5]

2025-05-30 Thread Paul Sandoz
On Thu, 29 May 2025 22:03:29 GMT, Ian Graves wrote: >> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been >> package-private. This propose change makes it public and adds documentation >> for it. > > Ian Graves has updated the pull request incrementally with one addition

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v5]

2025-05-29 Thread Ian Graves
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Updating copyrights

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v4]

2025-05-29 Thread Ian Graves
On Thu, 29 May 2025 21:52:30 GMT, Ian Graves wrote: >> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been >> package-private. This propose change makes it public and adds documentation >> for it. > > Ian Graves has updated the pull request incrementally with one addition

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v4]

2025-05-29 Thread Ian Graves
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Adding test coverage

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v3]

2025-05-29 Thread Ian Graves
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing tabbing -

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access [v2]

2025-05-29 Thread Ian Graves
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Tweaking doc language

Re: RFR: 8356634: VectorShape#largestShapeFor should have public access

2025-05-28 Thread Paul Sandoz
On Wed, 28 May 2025 21:22:30 GMT, Ian Graves wrote: > VectorShape#largestShapeFor is referenced in existing JavaDoc but has been > package-private. This propose change makes it public and adds documentation > for it. Can you add something to the method testVectorShape in test/jdk/jdk/incubato

RFR: 8356634: VectorShape#largestShapeFor should have public access

2025-05-28 Thread Ian Graves
VectorShape#largestShapeFor is referenced in existing JavaDoc but has been package-private. This propose change makes it public and adds documentation for it. - Commit messages: - Making VectorShape.largestShapeFor public and documenting Changes: https://git.openjdk.org/jdk/pull/2