Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Raffaello Giulietti
On Mon, 5 May 2025 20:58:56 GMT, Andrey Turbanov wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Increased min heap size to 8G. > > Marked as reviewed by aturbanov (Committer). Thanks to the reviewers, and

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Roger Riggs
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. Looks good,

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Claes Redestad
On Tue, 6 May 2025 08:44:56 GMT, Raffaello Giulietti wrote: >> @ForceInline >> static int checkOverflow(int value) { >> if (value >= 0) { >> return value; >> } >> throw new OutOfMemoryError("Overflow: String length out of range"); >> } >> >> priva

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Raffaello Giulietti
On Tue, 6 May 2025 08:22:51 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/StringConcatHelper.java line 435: >> >>> 433: static String doConcat(String s1, String s2) { >>> 434: byte coder = (byte) (s1.coder() | s2.coder()); >>> 435: int newLength = checkOver

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Shaojin Wen
On Tue, 6 May 2025 07:44:29 GMT, Claes Redestad wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Increased min heap size to 8G. > > src/java.base/share/classes/java/lang/StringConcatHelper.java line 435: > >

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-06 Thread Claes Redestad
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. LGTM src/j

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. Marked as r

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Increased min heap size to 8G. Test update

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v5]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Increased min heap size to 8G. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files - ne