Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 08:16:31 GMT, Jaikiran Pai wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No env to test > > src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 139: > >> 137: */ >> 138:

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 05:31:33 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> No env to test > > src/java.base/share/classes/jdk/internal/foreign/abi/CapturableState.java > line 96: > >> 94: public

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 04:50:30 GMT, Chen Liang wrote: >> Credit to @lukellmann that the duplication arg handling in #24742 avoided >> throwing exceptions but produced a wrong option. This patch fixes that and >> removed stream usages in CaptureCallState to speed up bootstrap. >> >> Also, the prev

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-05 Thread Jaikiran Pai
On Mon, 5 May 2025 04:50:30 GMT, Chen Liang wrote: >> Credit to @lukellmann that the duplication arg handling in #24742 avoided >> throwing exceptions but produced a wrong option. This patch fixes that and >> removed stream usages in CaptureCallState to speed up bootstrap. >> >> Also, the prev

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-04 Thread ExE Boss
On Mon, 5 May 2025 04:50:30 GMT, Chen Liang wrote: >> Credit to @lukellmann that the duplication arg handling in #24742 avoided >> throwing exceptions but produced a wrong option. This patch fixes that and >> removed stream usages in CaptureCallState to speed up bootstrap. >> >> Also, the prev

Re: RFR: 8356126: Revisit CaptureCallState [v4]

2025-05-04 Thread Chen Liang
> Credit to @lukellmann that the duplication arg handling in #24742 avoided > throwing exceptions but produced a wrong option. This patch fixes that and > removed stream usages in CaptureCallState to speed up bootstrap. > > Also, the previous patch affected the toString display of the option; I

Re: RFR: 8356126: Revisit CaptureCallState [v3]

2025-05-04 Thread Chen Liang
> Credit to @lukellmann that the duplication arg handling in #24742 avoided > throwing exceptions but produced a wrong option. This patch fixes that and > removed stream usages in CaptureCallState to speed up bootstrap. > > Also, the previous patch affected the toString display of the option; I

Re: RFR: 8356126: Revisit CaptureCallState [v2]

2025-05-04 Thread Chen Liang
> Credit to @lukellmann that the duplication arg handling in #24742 avoided > throwing exceptions but produced a wrong option. This patch fixes that and > removed stream usages in CaptureCallState to speed up bootstrap. > > Also, the previous patch affected the toString display of the option; I

Re: RFR: 8356126: Revisit CaptureCallState

2025-05-04 Thread Chen Liang
On Sun, 4 May 2025 22:51:21 GMT, Luca Kellermann wrote: >> Credit to @lukellmann that the duplication arg handling in #24742 avoided >> throwing exceptions but produced a wrong option. This patch fixes that and >> removed stream usages in CaptureCallState to speed up bootstrap. >> >> Also, the

Re: RFR: 8356126: Revisit CaptureCallState

2025-05-04 Thread Luca Kellermann
On Sun, 4 May 2025 22:37:21 GMT, Chen Liang wrote: > Credit to @lukellmann that the duplication arg handling in #24742 avoided > throwing exceptions but produced a wrong option. This patch fixes that and > removed stream usages in CaptureCallState to speed up bootstrap. > > Also, the previous

RFR: 8356126: Revisit CaptureCallState

2025-05-04 Thread Chen Liang
Credit to @lukellmann that the duplication arg handling in #24742 avoided throwing exceptions but produced a wrong option. This patch fixes that and removed stream usages in CaptureCallState to speed up bootstrap. Also, the previous patch affected the toString display of the option; I added a u