Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread duke
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Chen Liang
On Mon, 5 May 2025 18:59:29 GMT, Steffen Nießing wrote: >> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry >> for Lookup.findGetter. > > Steffen Nießing has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:01:54 GMT, Chen Liang wrote: > Thanks for the mailing list communication and reply. > > Check out https://openjdk.org/guide/ for more steps. For example, a patch > should usually wait 24 hours for sufficient reviews. @liach Thanks for the fast review and the creation of th

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-05 Thread Steffen Nießing
On Sun, 4 May 2025 17:20:29 GMT, Eirik Bjørsnøs wrote: > Nit: Would be nice if the PR title/description made it clear for the casual > reader that this is a documentation/Javadoc typo, as opposed to a code issue. Thanks for the hint. I've updated the PR accordingly. > This gives reviewers som

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter [v2]

2025-05-05 Thread Steffen Nießing
> JavaDoc only: This PR fixes a typo in the `bytecode behavior` table entry for > Lookup.findGetter. Steffen Nießing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull req

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-04 Thread Eirik Bjørsnøs
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote: > This PR fixes a typo in the bytecode cast for Lookup.findGetter. Just a tip for a newcomer: (Welcome!) It may be useful to flag this PR as “trivial” and “documentation-only” by saying something like “Please review this trivial, document

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-04 Thread Eirik Bjørsnøs
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote: > This PR fixes a typo in the bytecode cast for Lookup.findGetter. Nit: Would be nice if the PR title/description made it clear for the casual reader that this is a documentation/Javadoc typo, as opposed to a code issue. - PR

Re: RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-04 Thread Chen Liang
On Sun, 4 May 2025 16:45:11 GMT, Steffen Nießing wrote: > This PR fixes a typo in the bytecode cast for Lookup.findGetter. Thanks for the mailing list communication and reply. Check out https://openjdk.org/guide/ for more steps. For example, a patch should usually wait 24 hours for sufficient

RFR: 8356119: Typo in bytecode behavior for Lookup.findGetter

2025-05-04 Thread Steffen Nießing
This PR fixes a typo in the bytecode cast for Lookup.findGetter. - Commit messages: - 8356119: Correct field type for bytecode cast Changes: https://git.openjdk.org/jdk/pull/25024/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25024&range=00 Issue: https://bugs.openjdk.o