Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Luca Kellermann
On Tue, 13 May 2025 07:57:15 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Chen Liang
On Tue, 13 May 2025 14:39:36 GMT, Luca Kellermann wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address comments > > src/java.base/share/classes/java/util/ImmutableCollections.java line 1732: > >> 1730:

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Per Minborg
On Tue, 13 May 2025 07:57:15 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Chen Liang
On Tue, 13 May 2025 07:57:15 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v4]

2025-05-13 Thread Per Minborg
> This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Most of the efforts in this PR are to retain "stability" as long as possible > so that views of stable collections remain stable and do not evaluate on > `toString()` f

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-13 Thread Per Minborg
On Mon, 12 May 2025 07:42:16 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Per Minborg
On Mon, 12 May 2025 21:12:36 GMT, Luca Kellermann wrote: >> src/java.base/share/classes/java/util/ImmutableCollections.java line 518: >> >>> 516: >>> 517: private boolean allowNulls() { >>> 518: return root instanceof ListN listN && listN.allowNulls; >> >> I think this shou

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Luca Kellermann
On Mon, 12 May 2025 19:53:41 GMT, Luca Kellermann wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 386 commits: >> >> - Address comments >> - Merge branch 'master' into jep502-followup >> - Fix an issue wit

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Luca Kellermann
On Mon, 12 May 2025 07:42:16 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-12 Thread Luca Kellermann
On Fri, 9 May 2025 14:53:59 GMT, Chen Liang wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 384 commits: >> >> - Fix an issue with toString on nested constructs >> - Merge branch 'master' into jep502-follow

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Luca Kellermann
On Mon, 12 May 2025 07:42:16 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Chen Liang
On Mon, 12 May 2025 07:42:16 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Most of the efforts in this PR are to retain "stability" as long as possible >> so that views of stable collec

Re: RFR: 8356080: Address post-integration comments for Stable Values [v3]

2025-05-12 Thread Per Minborg
> This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-12 Thread Per Minborg
On Fri, 9 May 2025 14:55:06 GMT, Chen Liang wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 384 commits: >> >> - Fix an issue with toString on nested constructs >> - Merge branch 'master' into jep502-follow

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 12:10:38 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > Per Minborg has updated the pull re

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Maurizio Cimadamore
On Fri, 9 May 2025 12:10:38 GMT, Per Minborg wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > Per Minborg has updated the pull re

Re: RFR: 8356080: Address post-integration comments for Stable Values [v2]

2025-05-09 Thread Per Minborg
> This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-09 Thread Per Minborg
On Thu, 8 May 2025 16:08:24 GMT, Stuart Marks wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > src/java.base/share/classes/java/u

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-08 Thread Stuart Marks
On Fri, 2 May 2025 12:13:39 GMT, Per Minborg wrote: > This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. src/java.base/share/classes/java/util/Immu

RFR: 8356080: Address post-integration comments for Stable Values

2025-05-06 Thread Per Minborg
This PR proposes to address comments in the initial PR for Stable Values, which were deferred until after integration. Unfortunately, this PR shows the total commit history for stable values. - Commit messages: - Merge branch 'master' into jep502-followup - Update src/java.base/sh

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-06 Thread Chen Liang
On Fri, 2 May 2025 12:13:39 GMT, Per Minborg wrote: > This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. src/java.base/share/classes/java/lang/Stab

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-06 Thread ExE Boss
On Fri, 2 May 2025 13:56:19 GMT, Shaojin Wen wrote: >> This PR proposes to address comments in the initial PR for Stable Values, >> which were deferred until after integration. >> >> Unfortunately, this PR shows the total commit history for stable values. > > src/java.base/share/classes/jdk/int

Re: RFR: 8356080: Address post-integration comments for Stable Values

2025-05-06 Thread Shaojin Wen
On Fri, 2 May 2025 12:13:39 GMT, Per Minborg wrote: > This PR proposes to address comments in the initial PR for Stable Values, > which were deferred until after integration. > > Unfortunately, this PR shows the total commit history for stable values. src/java.base/share/classes/java/util/Immu