Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-08 Thread Julian Waters
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Tue, 6 May 2025 00:49:35 GMT, Julian Waters wrote: >> src/jdk.jpackage/windows/native/common/MsiUtils.h line 35: >> >>> 33: #include >>> 34: #include >>> 35: #include >> >> Why this include was added? > > It seemed to be needed to compile successfully back when I removed the kludge > hea

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Julian Waters
On Mon, 5 May 2025 22:23:04 GMT, Alexander Matveev wrote: >> kludge_c++11.h was introduced to work around older C++ versions not having >> access to C++ utilities like std::unique_ptr. Since we are already on C++14 >> (And hopefully will get C++17 soon) this workaround can be removed from >> j

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexander Matveev
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Alexey Semenyuk
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

Re: RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-05-05 Thread Julian Waters
On Fri, 25 Apr 2025 06:14:36 GMT, Julian Waters wrote: > kludge_c++11.h was introduced to work around older C++ versions not having > access to C++ utilities like std::unique_ptr. Since we are already on C++14 > (And hopefully will get C++17 soon) this workaround can be removed from > jpackage

RFR: 8355573: Remove kludge_c++11.h from jpackage code

2025-04-25 Thread Julian Waters
kludge_c++11.h was introduced to work around older C++ versions not having access to C++ utilities like std::unique_ptr. Since we are already on C++14 (And hopefully will get C++17 soon) this workaround can be removed from jpackage code. - Commit messages: - Include memory header