On Fri, 25 Apr 2025 19:41:54 GMT, Naoto Sato wrote:
>> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
>> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
>> Using `native.encoding` is appropriate so that the intention of the initial
>> test will hold.
On Fri, 25 Apr 2025 19:41:54 GMT, Naoto Sato wrote:
>> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
>> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
>> Using `native.encoding` is appropriate so that the intention of the initial
>> test will hold.
On Fri, 25 Apr 2025 19:37:17 GMT, Naoto Sato wrote:
>> test/jdk/java/io/pathNames/win32/SJIS.java line 32:
>>
>>> 30: */
>>> 31:
>>> 32: import java.io.*;
>>
>> Maybe don't use wildcard import?
>
> Fixed.
Thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24881#discus
On Fri, 25 Apr 2025 19:00:43 GMT, Brian Burkhalter wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Expand wild card imports
>
> test/jdk/java/io/pathNames/win32/SJIS.java line 32:
>
>> 30: */
>> 31:
>> 32: import j
> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
> Using `native.encoding` is appropriate so that the intention of the initial
> test will hold. Tested on an English Windows in which the system locale is
On Fri, 25 Apr 2025 17:02:30 GMT, Naoto Sato wrote:
> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
> Using `native.encoding` is appropriate so that the intention of the initial
> test will hold. Test
Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
Using `native.encoding` is appropriate so that the intention of the initial
test will hold. Tested on an English Windows in which the system locale is set
to
