Re: RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]

2025-04-23 Thread Alexander Matveev
On Wed, 23 Apr 2025 02:30:59 GMT, Alexey Semenyuk wrote: >> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. >> >> If signing identity validation fails, jpackage outputs three messages >> constructed from the following string IDs: `error.cert.not.found`, >> `error.explic

Re: RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]

2025-04-22 Thread Alexey Semenyuk
> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. > > If signing identity validation fails, jpackage outputs three messages > constructed from the following string IDs: `error.cert.not.found`, > `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`. > >

Re: RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]

2025-04-22 Thread Alexey Semenyuk
On Tue, 22 Apr 2025 21:48:16 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix whitespace > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 982: > >> 980:

Re: RFR: 8355328: Improve negative tests coverage for jpackage signing

2025-04-22 Thread Alexander Matveev
On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk wrote: > Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. > > If signing identity validation fails, jpackage outputs three messages > constructed from the following string IDs: `error.cert.not.found`, > `error.explicit-si

RFR: 8355328: Improve negative tests coverage for jpackage signing

2025-04-22 Thread Alexey Semenyuk
Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. If signing identity validation fails, jpackage outputs three messages constructed from the following string IDs: `error.cert.not.found`, `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`. `TKit.TextStr

Re: RFR: 8355328: Improve negative tests coverage for jpackage signing

2025-04-22 Thread Alexey Semenyuk
On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk wrote: > Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest. > > If signing identity validation fails, jpackage outputs three messages > constructed from the following string IDs: `error.cert.not.found`, > `error.explicit-si