Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]

2025-07-18 Thread Chen Liang
On Wed, 21 May 2025 21:31:16 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]

2025-05-23 Thread Roger Riggs
On Wed, 21 May 2025 21:31:16 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-21 Thread Chen Liang
On Wed, 21 May 2025 21:31:39 GMT, Roger Riggs wrote: >> I have appened this teaching paragraph also as a blockquote inlined note >> after this current paragraph. > > This unnecessary detail goes will beyond the description of the annotation > and is more of a design doc for VM implementation so

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-21 Thread Chen Liang
On Fri, 16 May 2025 19:45:16 GMT, John R Rose wrote: > Or just: s/, unlike the other methods// Removed mention of "the other methods". > src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java > line 90: > >> 88: * intrinsic.) For example, the documentation can simply

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v7]

2025-05-21 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-21 Thread Roger Riggs
On Wed, 21 May 2025 21:28:07 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java >> line 90: >> >>> 88: * intrinsic.) For example, the documentation can simply say that the >>> result is >>> 89: * undefined if a race happens. However, ra

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-21 Thread Chen Liang
On Wed, 21 May 2025 20:11:39 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java >> line 50: >> >>> 48: * For example, the bytecodes of a candidate method may be executed by >>> lower >>> 49: * compilation tiers of VM execution, while high

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-21 Thread Chen Liang
On Tue, 20 May 2025 06:08:37 GMT, Jaikiran Pai wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-20 Thread Chen Liang
On Tue, 20 May 2025 06:07:07 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java >> line 47: >> >>> 45: * intrinsics necessary. >>> 46: * >>> 47: * Intrinsification may never happen, or happen at any moment during >>> execution. >> >>

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-19 Thread Jaikiran Pai
On Wed, 30 Apr 2025 22:26:30 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-19 Thread Jaikiran Pai
On Wed, 30 Apr 2025 22:26:30 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-19 Thread Jaikiran Pai
On Fri, 16 May 2025 19:55:58 GMT, John R Rose wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits s

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-16 Thread John R Rose
On Wed, 30 Apr 2025 22:26:30 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-05-16 Thread John R Rose
On Wed, 30 Apr 2025 22:26:30 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v5]

2025-04-30 Thread Chen Liang
On Wed, 23 Apr 2025 14:12:29 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v6]

2025-04-30 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v5]

2025-04-30 Thread Roger Riggs
On Wed, 23 Apr 2025 14:12:29 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v5]

2025-04-23 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v4]

2025-04-23 Thread Raffaello Giulietti
On Tue, 22 Apr 2025 21:57:19 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v4]

2025-04-22 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v3]

2025-04-22 Thread John R Rose
On Tue, 22 Apr 2025 20:58:21 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v3]

2025-04-22 Thread John R Rose
On Tue, 22 Apr 2025 20:58:21 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread John R Rose
On Tue, 22 Apr 2025 21:01:13 GMT, Chen Liang wrote: >> In the new design, the above "footnotes" go at the bottom. They explain why >> the rules prescribed at the top are important. In effect, inform aggressive >> implementors how far they may bend those rules. Sometimes the rules do get >>

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread Chen Liang
On Tue, 22 Apr 2025 18:42:01 GMT, John R Rose wrote: >> And for arrays, a footnote might be appropriate: >> >> >> >> For some highly optimized algorithms, it may be impractical to ensure that >> array >> data is read or written only once by the intrinsic. If the caller of the >> intrinsic >

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread Chen Liang
On Mon, 21 Apr 2025 20:12:19 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v3]

2025-04-22 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread John R Rose
On Tue, 22 Apr 2025 18:38:42 GMT, John R Rose wrote: >> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java >> line 58: >> >>> 56: * The HotSpot VM checks, when loading a class, the consistency of >>> recognized >>> 57: * methods and {@code @IntrinsicCandidate} ann

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread John R Rose
On Tue, 22 Apr 2025 18:23:52 GMT, John R Rose wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refine validation and defensive copying > > src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-22 Thread John R Rose
On Mon, 21 Apr 2025 20:12:19 GMT, Chen Liang wrote: >> In offline discussion, we noted that the documentation on this annotation >> does not recommend minimizing the intrinsified section and moving whatever >> can be done in Java to Java; thus I prepared this documentation update, to >> shrink

Re: RFR: 8355223: Improve documentation on @IntrinsicCandidate [v2]

2025-04-21 Thread Chen Liang
> In offline discussion, we noted that the documentation on this annotation > does not recommend minimizing the intrinsified section and moving whatever > can be done in Java to Java; thus I prepared this documentation update, to > shrink a "TLDR" essay to something concise for readers, such as

RFR: 8355223: Improve documentation on @IntrinsicCandidate

2025-04-21 Thread Chen Liang
In offline discussion, we noted that the documentation on this annotation does not recommend minimizing the intrinsified section and moving whatever can be done in Java to Java; thus I prepared this documentation update, to shrink a "TLDR" essay to something concise for readers, such as pointing