Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

2025-04-21 Thread Alexander Matveev
On Tue, 22 Apr 2025 00:03:01 GMT, Alexey Semenyuk wrote: >> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 410: >> >>> 408: continue; >>> 409: } >>> 410: certs.add(cert); >> >> Maybe: >> >>

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v3]

2025-04-21 Thread Alexander Matveev
On Tue, 22 Apr 2025 00:14:17 GMT, Alexey Semenyuk wrote: >> Add tests for the following test cases: >> - Expired certificate specified for signing; >> - Multiple certificates with the same name in one keychain. >> >> Adding the new tests revealed an issue with MacCertificate - >> [JDK-8354989

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

2025-04-21 Thread Alexey Semenyuk
On Mon, 21 Apr 2025 23:02:33 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix compilation error > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 691: > >> 689:

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v3]

2025-04-21 Thread Alexey Semenyuk
> Add tests for the following test cases: > - Expired certificate specified for signing; > - Multiple certificates with the same name in one keychain. > > Adding the new tests revealed an issue with MacCertificate - > [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is >

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

2025-04-21 Thread Alexey Semenyuk
On Mon, 21 Apr 2025 22:36:08 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix compilation error > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 410: > >> 408:

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

2025-04-21 Thread Alexander Matveev
On Mon, 21 Apr 2025 21:34:59 GMT, Alexey Semenyuk wrote: >> Add tests for the following test cases: >> - Expired certificate specified for signing; >> - Multiple certificates with the same name in one keychain. >> >> Adding the new tests revealed an issue with MacCertificate - >> [JDK-8354989

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing

2025-04-21 Thread Alexey Semenyuk
On Fri, 18 Apr 2025 21:11:35 GMT, Alexey Semenyuk wrote: > Add tests for the following test cases: > - Expired certificate specified for signing; > - Multiple certificates with the same name in one keychain. > > Adding the new tests revealed an issue with MacCertificate - > [JDK-8354989](http

Re: RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

2025-04-21 Thread Alexey Semenyuk
> Add tests for the following test cases: > - Expired certificate specified for signing; > - Multiple certificates with the same name in one keychain. > > Adding the new tests revealed an issue with MacCertificate - > [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is >

RFR: 8354990: Improve negative tests coverage for jpackage signing

2025-04-18 Thread Alexey Semenyuk
Add tests for the following test cases: - Expired certificate specified for signing; - Multiple certificates with the same name in one keychain. Adding the new tests revealed an issue with MacCertificate - [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is also addressed