Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v3]

2025-04-21 Thread Lance Andersen
On Mon, 21 Apr 2025 16:19:30 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v3]

2025-04-21 Thread Naoto Sato
On Mon, 21 Apr 2025 16:19:30 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-21 Thread Joe Wang
On Mon, 21 Apr 2025 08:11:33 GMT, Andrey Turbanov wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > src/java.xml/share/classes/jdk/xml/internal/JdkXmlUtils.java lin

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v3]

2025-04-21 Thread Joe Wang
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug > report. > > Also in this patch: consolidates get and set properties to use the same Util > methods to reduce potential errors when code changes. > > Test: > Tier1 - 3 passed > JCK test passed Joe Wang has u

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-21 Thread Andrey Turbanov
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-19 Thread Joe Wang
On Sun, 20 Apr 2025 03:05:20 GMT, SendaoYan wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > test/jaxp/javax/xml/jaxp/unittest/common/PropertiesTest.java line 47:

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-19 Thread SendaoYan
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-18 Thread Naoto Sato
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote: >> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug >> report. >> >> Also in this patch: consolidates get and set properties to use the same Util >> methods to reduce potential errors when code changes. >> >> Test: >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 20:06:01 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/Pr

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-18 Thread Joe Wang
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug > report. > > Also in this patch: consolidates get and set properties to use the same Util > methods to reduce potential errors when code changes. > > Test: > Tier1 - 3 passed > JCK test passed Joe Wang has u

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE

2025-04-18 Thread Naoto Sato
On Thu, 17 Apr 2025 17:41:56 GMT, Joe Wang wrote: > Fix a NPE on calling DocumentBuilderFactory::getAttribute. This issue was > found during the previous JCK test (JCK-7322355). The JCK failure was from a > different method call, but it appears this is the root cause. > > Also in this patch: c

RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE

2025-04-17 Thread Joe Wang
Fix a NPE on calling DocumentBuilderFactory::getAttribute. This issue was found during the previous JCK test (JCK-7322355). The JCK failure was from a different method call, but it appears this is the root cause. Also in this patch: consolidates get and set properties to use the same Util metho