Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-18 Thread Stuart Marks
On Wed, 16 Apr 2025 13:20:33 GMT, Alan Bateman wrote: >> Stuart Marks has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v3]

2025-04-17 Thread Roger Riggs
On Thu, 17 Apr 2025 00:30:00 GMT, Stuart Marks wrote: >> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) >> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) >> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the >> na

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-17 Thread Stuart Marks
On Thu, 17 Apr 2025 00:26:49 GMT, Stuart Marks wrote: >> I belive they can be removed as they are no where used (and I don't think it >> will be used for `stdin.encoding` either) So I prefer removing those unused >> code now. > > OK, I've done so. Now testing on Windows (CI run built and p

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v3]

2025-04-17 Thread Naoto Sato
On Thu, 17 Apr 2025 00:30:00 GMT, Stuart Marks wrote: >> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) >> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) >> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the >> na

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v3]

2025-04-17 Thread Stuart Marks
> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) > sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) > sets native.encoding from sprops.sun_jnu_encoding. After this removal, the > native.encoding property will be set from sprops.encoding and

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-16 Thread Stuart Marks
On Wed, 16 Apr 2025 20:46:04 GMT, Naoto Sato wrote: >> The main focus of this commit is to straighten out the logic between the >> platform-specific and platform-independent layers. >> >> In the previous state of this file, tracing the origin of the properties on >> Windows, I ended up followi

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-16 Thread Naoto Sato
On Wed, 16 Apr 2025 17:44:36 GMT, Stuart Marks wrote: >> src/java.base/windows/native/libjava/java_props_md.c line 663: >> >>> 661:&sprops.format_country, >>> 662:&sprops.format_variant, >>> 663:&format_encoding_

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-16 Thread Stuart Marks
On Wed, 16 Apr 2025 14:43:45 GMT, Roger Riggs wrote: >> Stuart Marks has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-16 Thread Roger Riggs
On Wed, 16 Apr 2025 03:24:26 GMT, Stuart Marks wrote: >> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) >> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) >> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the >> na

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-16 Thread Alan Bateman
On Wed, 16 Apr 2025 03:24:26 GMT, Stuart Marks wrote: >> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) >> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) >> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the >> na

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-15 Thread Stuart Marks
On Tue, 15 Apr 2025 17:12:18 GMT, Naoto Sato wrote: >> src/java.base/share/native/libjava/System.c line 151: >> >>> 149: /* basic encoding properties, always non-NULL */ >>> 150: PUTPROP(propArray, _native_encoding_NDX, sprops->encoding); >>> 151: PUTPROP(propArray, _sun_jnu_encoding

Re: RFR: 8354464: Additional cleanup setting up native.encoding [v2]

2025-04-15 Thread Stuart Marks
> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) > sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) > sets native.encoding from sprops.sun_jnu_encoding. After this removal, the > native.encoding property will be set from sprops.encoding and

Re: RFR: 8354464: Additional cleanup setting up native.encoding

2025-04-15 Thread Naoto Sato
On Tue, 15 Apr 2025 17:04:35 GMT, Naoto Sato wrote: >> Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) >> sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) >> sets native.encoding from sprops.sun_jnu_encoding. After this removal, the >> nati

Re: RFR: 8354464: Additional cleanup setting up native.encoding

2025-04-15 Thread Naoto Sato
On Sat, 12 Apr 2025 02:19:35 GMT, Stuart Marks wrote: > Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) > sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) > sets native.encoding from sprops.sun_jnu_encoding. After this removal, the > native

RFR: 8354464: Additional cleanup setting up native.encoding

2025-04-14 Thread Stuart Marks
Remove the #ifdef MACOSX from platform-independent System.c, which (on Mac) sets native.encoding from sprops.encoding or (on non-Mac Unix and Windows) sets native.encoding from sprops.sun_jnu_encoding. After this removal, the native.encoding property will be set from sprops.encoding and the sun