Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows [v2]

2025-04-11 Thread Matthias Baesken
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote: >> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove >> it and make it UNIX-only (there are still a few remaining usages). > > Matthias Baesken has updated the pull request incrementally with one > additional co

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows [v2]

2025-04-11 Thread Martin Doerr
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote: >> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove >> it and make it UNIX-only (there a still a few remaining usages). > > Matthias Baesken has updated the pull request incrementally with one > additional comm

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows [v2]

2025-04-11 Thread Alan Bateman
On Fri, 11 Apr 2025 07:11:19 GMT, Matthias Baesken wrote: >> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove >> it and make it UNIX-only (there a still a few remaining usages). > > Matthias Baesken has updated the pull request incrementally with one > additional comm

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows [v2]

2025-04-11 Thread Matthias Baesken
> JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove > it and make it UNIX-only (there a still a few remaining usages). Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust COPYRIGHT years

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows [v2]

2025-04-11 Thread Matthias Baesken
On Thu, 10 Apr 2025 15:42:06 GMT, Alan Bateman wrote: > I think this looks okay, can you update the copyright header dates before you > integrate. Sure, I adjusted the copyright header dates. - PR Comment: https://git.openjdk.org/jdk/pull/24563#issuecomment-2796041681

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Alan Bateman
On Thu, 10 Apr 2025 08:03:58 GMT, Matthias Baesken wrote: > JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove > it and make it UNIX-only (there a still a few remaining usages). I think this looks okay, can you update the copyright header dates before you integrate. -

Re: RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Julian Waters
On Thu, 10 Apr 2025 08:03:58 GMT, Matthias Baesken wrote: > JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove > it and make it UNIX-only (there a still a few remaining usages). I was hoping to get around to using it on Windows, but oh well. I think the remaining usage

RFR: 8354189: Remove JLI_ReportErrorMessageSys on Windows

2025-04-10 Thread Matthias Baesken
JLI_ReportErrorMessageSys is not used any more on Windows, so we can remove it and make it UNIX-only (there a still a few remaining usages). - Commit messages: - JDK-8354189 Changes: https://git.openjdk.org/jdk/pull/24563/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=245