Re: RFR: 8353713: Improve Currency.getInstance exception handling [v2]

2025-04-07 Thread Naoto Sato
On Fri, 4 Apr 2025 23:03:23 GMT, Justin Lu wrote: >> Please review this PR which improves some Currency >> `IllegalArgumentException`s by including the input in the message. This >> could be a currency code, country code, or locale. This change also includes >> tests to check the messages for

Re: RFR: 8353713: Improve Currency.getInstance exception handling [v2]

2025-04-04 Thread Justin Lu
> Please review this PR which improves some Currency > `IllegalArgumentException`s by including the input in the message. This could > be a currency code, country code, or locale. This change also includes tests > to check the messages for an invalid country via the region override as well > as

Re: RFR: 8353713: Improve Currency.getInstance exception handling

2025-04-04 Thread Naoto Sato
On Fri, 4 Apr 2025 21:25:00 GMT, Justin Lu wrote: > Please review this PR which improves some Currency > `IllegalArgumentException`s by including the input in the message. This could > be a currency code, country code, or locale. This change also includes tests > to check the messages for an i

RFR: 8353713: Improve Currency.getInstance exception handling

2025-04-04 Thread Justin Lu
Please review this PR which improves some Currency `IllegalArgumentException`s by including the input in the message. This could be a currency code, country code, or locale. This change also includes tests to check the messages for an invalid country via the region override as well as an invalid