On Mon, 2 Jun 2025 04:42:03 GMT, David Holmes wrote:
> > When you say "most of the non-x86 platforms", are you referring to the ones
> > with processor types listed below?
>
> Yes - 3 of the 5 non-x86 platforms.
>
> > It looks like aarch64 and riscv don't take that route and would fall back
>
On Mon, 2 Jun 2025 03:49:42 GMT, Mohamed Issa wrote:
> When you say "most of the non-x86 platforms", are you referring to the ones
> with processor types listed below?
Yes - 3 of the 5 non-x86 platforms.
> It looks like aarch64 and riscv don't take that route and would fall back to
> the defa
On Mon, 2 Jun 2025 02:08:55 GMT, David Holmes wrote:
> This change also broke most of the non-x86 platforms, due to the new
> intrinsic not being implemented on those platforms.
When you say "most of the non-x86 platforms", are you referring to the ones
with processor types listed below?
1. j
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 29 May 2025 22:30:57 GMT, Mohamed Issa wrote:
>> Patch looks good to me, some comment included.
>
> @jatin-bhateja Please let me know if there's anything else to address.
@missa-prime The patch looks reasonable. It would have been nice if we (from
Oracle) could have tested it before in
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 30 May 2025 19:34:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 30 May 2025 19:03:00 GMT, Sandhya Viswanathan
wrote:
>> Mohamed Issa has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add newline back to templateInterpreterGenerator_x86_64.cpp source file
>> - Add special case values to cbrt
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 29 May 2025 18:56:11 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 29 May 2025 18:49:28 GMT, Mohamed Issa wrote:
>> test/micro/org/openjdk/bench/java/lang/CbrtPerf.java line 56:
>>
>>> 54: public static class CbrtPerfRanges {
>>> 55: public static int cbrtInputCount = 2048;
>>> 56:
>>
>> Please create separate CbrtPerfSpecialValues for +/-
On Thu, 29 May 2025 18:52:51 GMT, Mohamed Issa wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_cbrt.cpp line 49:
>>
>>> 47:
>>> /**/
>>> 48:
>>> 49: ATTRIBUTE_ALIGNED(4) static const juint _SIG_MASK[] =
>>
>> ATTRI
On Thu, 29 May 2025 08:36:31 GMT, Jatin Bhateja wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
On Thu, 29 May 2025 08:21:29 GMT, Jatin Bhateja wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
On Thu, 29 May 2025 09:01:05 GMT, Julian Waters wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Wed, 28 May 2025 18:39:13 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Wed, 28 May 2025 18:39:13 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Wed, 28 May 2025 18:36:38 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Tue, 27 May 2025 22:30:17 GMT, Sandhya Viswanathan
wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new set of cbrt micro-benchmarks
>
> src/hotspot/cpu/x86/macroAssembler_x86.hpp line 1251:
>
>> 1249: vo
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Tue, 6 May 2025 21:45:34 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regressions
On Tue, 6 May 2025 21:45:34 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regressions
On Wed, 7 May 2025 09:25:30 GMT, Andrew Haley wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new set of cbrt micro-benchmarks
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_cbrt.cpp line 62:
>
>> 60: {
>> 61:
On Tue, 6 May 2025 21:45:34 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regressions
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm.
>
> The results of all tests posted below were captured with an [Intel® Xeon
> 6761P](https://www.intel.com/content/www/us/en/products/sku/241842/intel-xeon-6761p-processor-336m-cache-2-50-ghz/speci
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm.
>
> The results of all tests posted below were captured with an [Intel® Xeon
> 6761P](https://www.intel.com/content/www/us/en/products/sku/241842/intel-xeon-6761p-processor-336m-cache-2-50-ghz/speci
On Sat, 26 Apr 2025 10:04:38 GMT, Andrew Haley wrote:
> What are the monotonicity and accuracy results for this approximation? Is it
> correctly rounded or faithfully rounded?
1. It's monotonic.
2. It has a maximum error of 0.5213 ULP.
3. It's not correctly rounded but it is faithfully rounded.
On Sat, 26 Apr 2025 11:01:58 GMT, Andrew Haley wrote:
> > the built in **cbrt** micro-benchmark
>
> How should we run that benchmark? Thanks.
`make test TEST="micro:MathBench.cbrt"`
-
PR Comment: https://git.openjdk.org/jdk/pull/24470#issuecomment-2840442518
On Sun, 6 Apr 2025 03:48:22 GMT, Mohamed Issa wrote:
> the built in **cbrt** micro-benchmark
How should we run that benchmark? Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/24470#issuecomment-2832035668
On Sun, 6 Apr 2025 03:48:22 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm.
>
> The results of all tests posted below were captured with an [Intel® Xeon
> 6761P](https://www.intel.com/content/www/us/en/products/sku/2418
The goal of this PR is to implement an x86_64 intrinsic for
java.lang.Math.cbrt() using libm.
The results of all tests posted below were captured with an [Intel® Xeon
6761P](https://www.intel.com/content/www/us/en/products/sku/241842/intel-xeon-6761p-processor-336m-cache-2-50-ghz/specifications.
34 matches
Mail list logo
