Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-15 Thread PAWAN CHAWDHARY
On Wed, 14 May 2025 09:41:58 GMT, Sergey Chernyshev wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-15 Thread PAWAN CHAWDHARY
On Tue, 13 May 2025 14:46:00 GMT, Ivan Bereziuk wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > The change looks good. There might be some issues with container engine

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Mikhailo Seledtsov
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code Overall cha

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Sergey Chernyshev
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code test/hotspo

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Sergey Chernyshev
On Tue, 13 May 2025 14:46:00 GMT, Ivan Bereziuk wrote: > I wrote 2 comments. but cold not post them. They are in "pending" state. Not > sure why. Should the comments be first reviewed by {Committers|Reviewers}? please go to `Files changed` panel and press Review Changes -> Submit review --

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-13 Thread Ivan Bereziuk
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code The change

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-02 Thread PAWAN CHAWDHARY
On Tue, 29 Apr 2025 20:18:17 GMT, Sergey Chernyshev wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-02 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: Refactor container runtime version code - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files