On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 15:59:24 GMT, Naoto Sato wrote:
>> src/java.base/windows/native/libjava/java_props_md.c line 142:
>>
>>> 140: cp = GetConsoleOutputCP();
>>> 141: } else {
>>> 142: cp = GetConsoleCP();
>>
>> Just a reminder that we should handle the case where GetConsoleX
On Thu, 27 Mar 2025 16:12:24 GMT, Alan Bateman wrote:
>> Ah, you mentioned it before which I forgot! Handled the error case too.
>
> How is NULL handled in the callers?
Those system properties will be substituted with `native.encoding`
https://github.com/openjdk/jdk/blob/dc5c4148c70ca43d0a69c326
On Thu, 27 Mar 2025 16:11:47 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handled the error case
>
> src/java.base/windows/native/libjava/java_props_md.c line 131:
>
>> 129: }
>> 130:
>> 131: s
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
On Thu, 27 Mar 2025 07:36:07 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects the review comment
>
> src/java.base/windows/native/libjava/java_props_md.c line 142:
>
>> 140: cp = Ge
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as both calls return the same value by default
> (`GetOEMCP
On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as both calls return the same value by default
> (`GetOEMCP
On Wed, 26 Mar 2025 20:57:47 GMT, Naoto Sato wrote:
>> Those system property values on Windows were derived from Windows'
>> `GetConsoleCP()` call, but they should have been taken from
>> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
>> won't change any behavior, as
Those system property values on Windows were derived from Windows'
`GetConsoleCP()` call, but they should have been taken from
`GetConsoleOutputCP()`. Replacing the incorrect call with the correct one won't
change any behavior, as both calls return the same value by default
(`GetOEMCP()`). Howe
On Wed, 26 Mar 2025 19:19:03 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects the review comment
>
> src/java.base/windows/native/libjava/java_props_md.c line 131:
>
>> 129: }
>> 130:
>> 1
On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato wrote:
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as bot
On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato wrote:
> Those system property values on Windows were derived from Windows'
> `GetConsoleCP()` call, but they should have been taken from
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one
> won't change any behavior, as bot
16 matches
Mail list logo
