Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v4]

2025-04-22 Thread Chen Liang
On Wed, 16 Apr 2025 12:07:45 GMT, Jan Lahoda wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pr

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v4]

2025-04-16 Thread Jan Lahoda
> The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problematic - JLine is > very powerful, possibly too powerfu

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v2]

2025-04-05 Thread Jan Lahoda
> The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problematic - JLine is > very powerful, possibly too powerfu

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-05 Thread Jan Lahoda
On Thu, 27 Mar 2025 18:28:17 GMT, Naoto Sato wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pr

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-05 Thread Magnus Ihse Bursie
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-04 Thread Jan Lahoda
On Mon, 31 Mar 2025 17:22:45 GMT, David M. Lloyd wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewha

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v3]

2025-04-04 Thread Magnus Ihse Bursie
On Thu, 3 Apr 2025 18:12:54 GMT, Jan Lahoda wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pro

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v2]

2025-04-03 Thread Jan Lahoda
On Thu, 3 Apr 2025 17:59:52 GMT, Jan Lahoda wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pro

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v3]

2025-04-03 Thread Jan Lahoda
> The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problematic - JLine is > very powerful, possibly too powerfu

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-01 Thread David M . Lloyd
On Tue, 1 Apr 2025 11:18:14 GMT, Jan Lahoda wrote: >> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java >> line 75: >> >>> 73: } >>> 74: continue READ; >>> 75: case '\033': >> >> If this is meant to be platfo

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-31 Thread Jan Lahoda
On Thu, 27 Mar 2025 20:48:22 GMT, Naoto Sato wrote: >> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java >> line 198: >> >>> 196: >>> 197: if (it.hasNext()) { >>> 198: out.append("\n\r"); >> >> I understand this is a simple console, bu

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-31 Thread David M . Lloyd
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-31 Thread Naoto Sato
On Mon, 31 Mar 2025 17:04:55 GMT, Jan Lahoda wrote: >> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java >> line 69: >> >>> 67: case 4: break READ; //EOF/Ctrl-D >>> 68: case 127: >>> 69: //backspace: >> >> Is it

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-31 Thread Jan Lahoda
On Mon, 31 Mar 2025 12:43:26 GMT, Magnus Ihse Bursie wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a som

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-31 Thread Magnus Ihse Bursie
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-27 Thread Naoto Sato
On Thu, 27 Mar 2025 19:29:29 GMT, Naoto Sato wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pr

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-27 Thread Naoto Sato
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-26 Thread Jan Lahoda
On Wed, 26 Mar 2025 08:59:39 GMT, Alan Bateman wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-26 Thread Jan Lahoda
On Wed, 26 Mar 2025 08:55:09 GMT, Alan Bateman wrote: > Can you coordinate with Naoto on this? There is a CSR in progress to switch > Console back to using the java.base implementation by default. Right - but that still keeps the existing JLine-based provider, and so the problems it has still

RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-26 Thread Jan Lahoda
The `java.io.Console` has several backends: a simple on in `java.base`, a more convenient one in `jdk.internal.le` (with line-reading based on JLine) and one for JShell. The backend based on JLine is proving to be a somewhat problematic - JLine is very powerful, possibly too powerful and comple

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-26 Thread Alan Bateman
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem