Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-15 Thread Thomas Stuefe
On Wed, 14 May 2025 00:32:08 GMT, David Holmes wrote: >> Hmm, glibc keeps it very vague in the vfork() manpage, stating that "On some >> implementations, vfork() is equivalent to fork()." AIX manpage says just >> "The vfork subroutine is supported as a compatibility interface for older >> Berk

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-14 Thread Aleksey Shipilev
On Tue, 13 May 2025 10:30:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread David Holmes
On Tue, 13 May 2025 12:51:56 GMT, Thomas Stuefe wrote: >> You are right and I am confused. I always assumed that the primary function >> of jspawnhelper was to make vfork safe. Historically, that was the typical >> reason for an intermediate exec() to a helper - basically, you first exec() >>

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-13 Thread Aleksey Shipilev
On Tue, 13 May 2025 10:30:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-13 Thread Roger Riggs
On Tue, 13 May 2025 10:30:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-13 Thread Volker Simonis
On Tue, 13 May 2025 10:30:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Aleksey Shipilev
On Wed, 30 Apr 2025 16:06:23 GMT, Roger Riggs wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Thomas Stuefe
On Tue, 13 May 2025 12:47:39 GMT, Thomas Stuefe wrote: >> Er? This is news to me. Where do you see this? I see we only pass the >> `helperpath` (carrying `jspawnhelper` path only to `POSIX_SPAWN` mode: >> >> >> static pid_t >> startChild(JNIEnv *env, jobject process, ChildStuff *c, const char

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-13 Thread Thomas Stuefe
On Tue, 13 May 2025 10:30:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Thomas Stuefe
On Tue, 13 May 2025 10:26:51 GMT, Aleksey Shipilev wrote: >> src/java.base/unix/native/libjava/ProcessImpl_md.c line 346: >> >>> 344: if (ret != EINVAL) >>> 345: detail = tmpbuf; >>> 346: } >> >> Pre-existing, possibly as follow-up: >> >> I wonder whether we can do mor

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Thomas Stuefe
On Tue, 13 May 2025 09:13:58 GMT, Aleksey Shipilev wrote: >> src/java.base/unix/native/libjava/ProcessImpl_md.c line 377: >> >>> 375: throwIOExceptionImpl(env, errnum, defaultDetail, ""); >>> 376: } >>> 377: } >> >> Why only for POSIX_SPAWN? We use jspawnhelper also for fork/vfork+exec.

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Aleksey Shipilev
On Tue, 6 May 2025 11:23:32 GMT, Thomas Stuefe wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v5]

2025-05-13 Thread Aleksey Shipilev
> When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > application is configured to only capture the exception logs (e.g.

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Aleksey Shipilev
On Tue, 6 May 2025 10:56:54 GMT, Thomas Stuefe wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-13 Thread Aleksey Shipilev
On Tue, 6 May 2025 10:51:14 GMT, Thomas Stuefe wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-06 Thread Thomas Stuefe
On Wed, 30 Apr 2025 16:11:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-05-06 Thread Thomas Stuefe
On Wed, 30 Apr 2025 17:26:09 GMT, Aleksey Shipilev wrote: > @tstuefe -- I know you love `jspawnhelper` bugs, want to take a look? Love is a strong word :-) I missed this one. I will take a look. - PR Comment: https://git.openjdk.org/jdk/pull/24149#issuecomment-2853797278

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-04-30 Thread Aleksey Shipilev
On Wed, 30 Apr 2025 16:11:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-04-30 Thread #NotTheOne
On Wed, 30 Apr 2025 16:11:14 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-04-30 Thread Roger Riggs
On Wed, 30 Apr 2025 16:07:56 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-04-30 Thread Aleksey Shipilev
On Wed, 30 Apr 2025 14:50:03 GMT, Roger Riggs wrote: > Please add the test number 8352533 to the @bug tag in Basic.java. Thanks, added! - PR Comment: https://git.openjdk.org/jdk/pull/24149#issuecomment-2842494196

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v4]

2025-04-30 Thread Aleksey Shipilev
> When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > application is configured to only capture the exception logs (e.g.

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-04-30 Thread Roger Riggs
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-04-30 Thread Aleksey Shipilev
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-04-14 Thread Aleksey Shipilev
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-04-04 Thread Aleksey Shipilev
When jspawnhelper fails for whatever reason, but more prominently due to [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report the errors into stdout, but not to the relevant `IOException`. So, if the application is configured to only capture the exception logs (e.g. through

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-03-28 Thread Aleksey Shipilev
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-03-26 Thread Aleksey Shipilev
> When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > application is configured to only capture the exception logs (e.g.

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v2]

2025-03-26 Thread Aleksey Shipilev
> When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > application is configured to only capture the exception logs (e.g.

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v3]

2025-03-26 Thread Volker Simonis
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> ap

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails [v2]

2025-03-26 Thread Aleksey Shipilev
On Tue, 25 Mar 2025 23:58:36 GMT, Volker Simonis wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Volker Simonis
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote: > When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > applic

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Dan Lutker
On Tue, 25 Mar 2025 19:38:27 GMT, Aleksey Shipilev wrote: >> src/java.base/unix/native/libjava/ProcessImpl_md.c line 324: >> >>> 322: #define SPAWN_HELPER_INTERNAL_ERROR_MSG "\n" \ >>> 323: "Possible reasons:\n" \ >>> 324: " - Spawn helper ran into JDK version or configuration problems\n" \

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Aleksey Shipilev
On Tue, 25 Mar 2025 19:35:36 GMT, Dan Lutker wrote: >> When jspawnhelper fails for whatever reason, but more prominently due to >> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report >> the errors into stdout, but not to the relevant `IOException`. So, if the >> applicat

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-25 Thread Dan Lutker
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote: > When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > applic

Re: RFR: 8352533: Report useful IOExceptions when jspawnhelper fails

2025-03-21 Thread Aleksey Shipilev
On Fri, 21 Mar 2025 10:00:26 GMT, Aleksey Shipilev wrote: > When jspawnhelper fails for whatever reason, but more prominently due to > [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report > the errors into stdout, but not to the relevant `IOException`. So, if the > applic