On Sat, 19 Apr 2025 20:09:59 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
On Wed, 16 Apr 2025 00:05:44 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minors
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorTest.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2022, 2025,Ora
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Fri, 11 Apr 2025 10:48:34 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
On Mon, 14 Apr 2025 03:24:18 GMT, Feilong Jiang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minors
>
> Looks good. Thanks!
Thank you @feilongjiang @RealFYang !
-
PR Comment: https://git.openjdk.org/
On Mon, 14 Apr 2025 06:26:10 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minors
>
> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 149:
>
>> 147: "UseZbb",
On Fri, 11 Apr 2025 10:48:34 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
On Fri, 11 Apr 2025 10:48:34 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
On Fri, 11 Apr 2025 04:07:45 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> enable more test
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2173:
>
>> 2171: break;
>> 2172: case B
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Thu, 10 Apr 2025 12:08:29 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> On riscv, CMoveI/L already were implemented, but there are some gap:
>> 1. CMoveI/L does not support comparison with float/double, corresponding
>> tests are not turn on either.
>> 2. Some optimiza
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Wed, 9 Apr 2025 06:52:26 GMT, Fei Yang wrote:
>> This is to not enable Zicond automatically, but user can still turn it on
>> manually if they want to try or make sure it bring benefit on the specific
>> hardware.
>> Currently it's based on bananapi result, so maybe in the future we should
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Wed, 9 Apr 2025 06:41:51 GMT, Fei Yang wrote:
> Sorry for not being clear enough. I am suggesting this:
if (UseZicond) {
FLAG_SET_DEFAULT(ConditionalMoveLimit, 3);
}
I think this depends on whether we should enable ConditionalMoveLimit based on
`UseZicond`? So, I'll leave it until
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`
On Tue, 8 Apr 2025 15:02:27 GMT, Feilong Jiang wrote:
>> Hamlin Li has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>> si
On Tue, 8 Apr 2025 10:29:38 GMT, Hamlin Li wrote:
> > Maybe we should check UseZicond and only enable UseCMoveUnconditionally &
> > ConditionalMoveLimit conditionally?
>
> Not sure what do you mean here.
Sorry for not being clear enough. I am suggesting this:
if (UseZicond) {
FLAG_SET_
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> the reason is the generated code by Zicond is much larger than branch version
I'm curious about this one. It's surprising to me that we see bigger code
generated with Zicond. Do you know why that is the case?
-
PR Comment: https:
On Tue, 8 Apr 2025 07:07:12 GMT, Fei Yang wrote:
> Maybe we should check UseZicond and only enable UseCMoveUnconditionally &
> ConditionalMoveLimit conditionally?
Not sure what do you mean here.
> I don't see how enabling CMove will bring us any performance benefit without
> Zicond. It's done
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> On riscv, CMoveI/L already were implemented, but there are some gap:
> 1. CMoveI/L does not support comparison with float/double, corresponding
> tests are not turn on either.
> 2. Some optimization of
Hi,
Can you help to review this patch?
On riscv, CMoveI/L already were implemented, but there are some gap:
1. CMoveI/L does not support comparison with float/double, corresponding tests
are not turn on either.
2. Some optimization of C2 is not turned on, e.g. `Phi -> CMove -> min_max`.
3. lack of
27 matches
Mail list logo
