On Wed, 19 Mar 2025 00:43:28 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only.
>>
>> DTD
On Tue, 18 Mar 2025 18:27:56 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test: change variables and etc.
>
> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSc
On Wed, 19 Mar 2025 00:43:28 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only.
>>
>> DTD
On Tue, 18 Mar 2025 19:55:39 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSchema.dtd
>> line 8:
>>
>>> 6:
>>>
>>> 7:
>>>
>>> 8:
>>>
>>
>> The other XML comments use the multi-line format with a single begin
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only.
>
> DTD files: the Schema 1.1 files, XMLSchema.dtd and datatypes.
On Tue, 18 Mar 2025 19:05:32 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test: change variables and etc.
>
> test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line
On Tue, 18 Mar 2025 18:26:09 GMT, Roger Riggs wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the test: change variables and etc.
>
> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSc
On Tue, 18 Mar 2025 18:50:24 GMT, Roger Riggs wrote:
> The XMLSchema.dtd changes the referenced version from the 2009 version to the
> 2001 version. Is that intentional.
Yes. Note the Public Identifier: "-//W3C//DTD XSD 1.1//EN" vs "-//W3C//DTD
XMLSCHEMA 200102//EN" at line 2. The 2009 version
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
On Fri, 14 Mar 2025 18:35:12 GMT, Joe Wang wrote:
> Thanks for review. Updated the test.
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/24039#issuecomment-2729299732
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote:
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
> Shema 1.0 DTDs.
Looks good to me, just a few very minor questions. Thank you
test/jaxp
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
> Shema 1.0 DTDs.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
update the test
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote:
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
> Shema 1.0 DTDs.
Thanks for review. Updated the test.
-
PR Comment: https:
Add public identifiers to the JDK built-in Catalog; Replace the incorrect
Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
Shema 1.0 DTDs.
-
Commit messages:
- 8351969: Add Public Identifiers to the JDK built-in Catalog
Changes: https://git.openjdk.org/
17 matches
Mail list logo
