Re: RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-09 Thread Viktor Klang
On Wed, 9 Apr 2025 05:56:28 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/VirtualThread.java line 889: >> >>> 887: private void parkTimeoutExpired() { >>> 888: assert !VirtualThread.currentThread().isVirtual(); >>> 889: if (!getAndSetParkPermit(true) >> >

Re: RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-09 Thread Viktor Klang
On Thu, 13 Mar 2025 10:48:14 GMT, Alan Bateman wrote: > Follow up to JDK-8319447 to change the VirtualThread implementation to use > FJP's delayed task handling. > > The SPTE based implementation is not removed. It will continue to be used by > tests. If custom schedulers are exposed in the fu

Re: RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-09 Thread Alan Bateman
On Wed, 9 Apr 2025 08:03:44 GMT, Viktor Klang wrote: >> It already does, no CAS if the current value is the new value. > > I meant the park permit. :) getAndSetParkPermit isn't changed in this PR. If the park permit is already granted then getAndSetParkPermit(true) doesn't do anything. More gen

Re: RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-08 Thread Alan Bateman
On Tue, 8 Apr 2025 20:05:26 GMT, Viktor Klang wrote: >> Follow up to JDK-8319447 to change the VirtualThread implementation to use >> FJP's delayed task handling. >> >> The SPTE based implementation is not removed. It will continue to be used by >> tests. If custom schedulers are exposed in th

Re: RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-08 Thread Viktor Klang
On Thu, 13 Mar 2025 10:48:14 GMT, Alan Bateman wrote: > Follow up to JDK-8319447 to change the VirtualThread implementation to use > FJP's delayed task handling. > > The SPTE based implementation is not removed. It will continue to be used by > tests. If custom schedulers are exposed in the fu

RFR: 8351927: Change VirtualThread implementation to use use FJP delayed task handling

2025-04-08 Thread Alan Bateman
Follow up to JDK-8319447 to change the VirtualThread implementation to use FJP's delayed task handling. The SPTE based implementation is not removed. It will continue to be used by tests. If custom schedulers are exposed in the future then they will use this implementation. For timed-Object.wa