Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v3]

2025-04-10 Thread Naoto Sato
On Thu, 10 Apr 2025 18:14:52 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Cha

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v3]

2025-04-10 Thread Stuart Marks
On Thu, 10 Apr 2025 18:14:52 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Cha

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Stuart Marks
On Thu, 10 Apr 2025 18:11:06 GMT, Stuart Marks wrote: >> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 79: >> >>> 77: // Platform defined encodings cannot be overridden on the >>> command line >>> 78: put(props, "sun.jnu.encoding", >>> raw.propDefault(Raw.

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Stuart Marks
On Thu, 10 Apr 2025 08:31:40 GMT, Alan Bateman wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comment from file.encoding to native.encoding > > src/java.base/share/classes/jdk/internal/util/SystemProps.java li

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v3]

2025-04-10 Thread Stuart Marks
> Some of the code that creates various encoding properties at JVM > initialization time, such as file.encoding and native.encoding, could use > some cleaning up. Cleanup is fairly minimal and should be mostly > behavior-preserving. Changes include the following: > > * In the java_props.h and j

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Roger Riggs
On Mon, 7 Apr 2025 23:43:29 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Chan

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-10 Thread Alan Bateman
On Mon, 7 Apr 2025 23:43:29 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Chan

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-09 Thread Naoto Sato
On Mon, 7 Apr 2025 23:43:29 GMT, Stuart Marks wrote: >> Some of the code that creates various encoding properties at JVM >> initialization time, such as file.encoding and native.encoding, could use >> some cleaning up. Cleanup is fairly minimal and should be mostly >> behavior-preserving. Chan

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-09 Thread Stuart Marks
> Some of the code that creates various encoding properties at JVM > initialization time, such as file.encoding and native.encoding, could use > some cleaning up. Cleanup is fairly minimal and should be mostly > behavior-preserving. Changes include the following: > > * In the java_props.h and j

Re: RFR: 8351740: Clean up some code around initialization of encoding properties [v2]

2025-04-07 Thread Stuart Marks
On Mon, 7 Apr 2025 17:15:34 GMT, Naoto Sato wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comment from file.encoding to native.encoding > > src/java.base/share/native/libjava/System.c line 153: > >> 151:

Re: RFR: 8351740: Clean up some code around initialization of encoding properties

2025-04-07 Thread Naoto Sato
On Fri, 4 Apr 2025 23:42:26 GMT, Stuart Marks wrote: > Some of the code that creates various encoding properties at JVM > initialization time, such as file.encoding and native.encoding, could use > some cleaning up. Cleanup is fairly minimal and should be mostly > behavior-preserving. Changes

RFR: 8351740: Clean up some code around initialization of encoding properties

2025-04-04 Thread Stuart Marks
Various behavior-preserving code cleanups related to system properties related to character encodings. - Commit messages: - More minor cleanups, reversion of some extra changes. - WIP: add some non-null asserts and comments on sprops encoding members - A couple small tweaks. - Me