On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 10:35:10 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move the timestamp to before the try block, change bytes to bytesWritten
>> and remove unnecessary code
>
> src/java.bas
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:51:51 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove the mistakenly added file.
>> - Fix whitespace
>
> src/jdk.jfr/share/conf/jfr/default.jfc line 845:
>
>> 843:
On Thu, 5 Jun 2025 10:10:41 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 09:31:39 GMT, Erik Gahlin wrote:
>> I think we (from both the java.base and jdk.jfr perspectives) need to keep
>> an eye on the complexity of the use sites. The new throttling stuff requires
>> a new local variable. By itself this isn't a big deal, but there are 12
>> events
On Thu, 5 Jun 2025 09:37:45 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Thu, 5 Jun 2025 00:21:45 GMT, Stuart Marks wrote:
>> We need some indication of which events are throttleable and looking at the
>> mirror event may not work in some scenarios.
>>
>> We need to sample the endTime, because the startTime may be several minutes
>> in the past. We could use com
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
On Thu, 5 Jun 2025 09:26:13 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incremen
On Thu, 5 Jun 2025 08:40:44 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
> Could I have review of an enhancement that adds rate-limited sampling to Java
> events, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request with a n
On Wed, 4 Jun 2025 16:04:08 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/java/net/Socket.java line 970:
>>
>>> 968: long end = SocketReadEvent.timestamp();
>>> 969: long duration = end - start;
>>> 970: if (SocketReadEvent.shouldThrottleCommit(durati
On Wed, 4 Jun 2025 14:32:31 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/java.base/share/classes/java/net/Socket.java line 970:
>
>> 968: long end = Sock
On Wed, 4 Jun 2025 14:16:56 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/jdk.jfr/share/classes/jdk/jfr/Throttle.java line 77:
>
>> 75: * Specifying {@code "off"
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Wed, 4 Jun 2025 11:31:21 GMT, Erik Gahlin wrote:
> @AlanBateman Do you have time for a review?
Yes, looking at the changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/25559#issuecomment-2939787559
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
On Tue, 3 Jun 2025 12:50:49 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java events, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Tha
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request increment
On Mon, 2 Jun 2025 08:59:57 GMT, Volkan Yazici wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Some reviewer feedback
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/settings/Throttler.java line 30:
>
>> 28: import
On Sun, 1 Jun 2025 13:07:50 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line
>> 256:
>>
>>> 254: // }
>>> 255: getEventConfiguration(codeBuilder);
>>> 256: codeBuilder.aload(0);
>>
>> Can issue a dup() here
On Sun, 1 Jun 2025 20:56:50 GMT, Erik Gahlin wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java event, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>> Than
On Sat, 31 May 2025 21:20:17 GMT, Markus Grönlund wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Some reviewer feedback
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 261:
>
>> 259:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> Erik
Erik Gahlin has updated the pull request increment
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Sat, 31 May 2025 20:13:01 GMT, Markus Grönlund wrote:
>> Could I have review of an enhancement that adds rate-limited sampling to
>> Java event, including five events in the JDK (SocketRead, SocketWrite,
>> FileRead, FileWrite, and JavaExceptionThrow).
>>
>> Testing: test/jdk/jdk/jfr
>>
>>
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
> FileWrite, and JavaExceptionThrow).
>
> Testing: test/jdk/jdk/jfr
>
> Thanks
> E
Could I have review of an enhancement that adds rate-limited sampling to Java
event, including five events in the JDK (SocketRead, SocketWrite, FileRead,
FileWrite, and JavaExceptionThrow).
Testing: test/jdk/jdk/jfr
Thanks
Erik
-
Commit messages:
- Consistent annotation
- Fix ty
44 matches
Mail list logo
