On Sat, 17 May 2025 15:04:21 GMT, Markus KARG wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed extraneous "the"
>
> src/java.base/share/classes/java/lang/StringUTF16.java line 1535:
>
>> 1533: checkB
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 9 May 2025 16:41:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Fri, 9 May 2025 13:28:44 GMT, Raffaello Giulietti
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add an assert to inflateToUTF16 method
>> Add doc of preconditions to appendChars... methods
>> Correct misc
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Tue, 6 May 2025 16:18:11 GMT, Chen Liang wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply reviewer suggestions for typos, javadoc, and copyright dates.
>
> src/java.base/share/classes/java/lang/AbstractStrin
On Fri, 9 May 2025 00:20:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:23:39 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Tue, 6 May 2025 15:19:09 GMT, Johannes Graham wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor to consistently use `isLatin1(coder)` within
>> AbstractStringBuilder.
>
> src/java.base/share/classes/java/
On Tue, 6 May 2025 15:07:25 GMT, Roger Riggs wrote:
> > I see that in the proposed changes, we are now using the same names for
> > these local variables and method parameters as the field names. Would using
> > different names for these local variables be better? To avoid shadowing the
> > fi
On Tue, 6 May 2025 13:59:40 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor to consistently use `isLatin1(coder)` within
>> AbstractStringBuilder.
>
> test/jdk/java/lang/StringBuilder/Str
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Tue, 6 May 2025 13:03:37 GMT, Jaikiran Pai wrote:
> I see that in the proposed changes, we are now using the same names for these
> local variables and method parameters as the field names. Would using
> different names for these local variables be better? To avoid shadowing the
> field nam
On Tue, 6 May 2025 01:38:21 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor to consistently use `isLatin1(coder)` within
>> AbstractStringBuilder.
>
> src/java.base/share/classes/java/lan
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 2 May 2025 17:49:20 GMT, Shaojin Wen wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Optimize StringUTF16.putCharsAt a bit.
>> Fixup hotspot Helper of putCharsAt to remove return value to match
>> StringU
On Mon, 5 May 2025 17:58:09 GMT, Roger Riggs wrote:
>> In fact, `StringUTF16` and `StringLatin1` are both package-private, so
>> technically all their method access modifiers should either be
>> package-private or private.
>
> How about in another PR. None of the `public static ` methods in St
On Mon, 5 May 2025 17:38:55 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/StringUTF16.java line 1531:
>>
>>> 1529: }
>>> 1530:
>>> 1531: public static void putCharsAt(byte[] value, int i, char c1, char
>>> c2, char c3, char c4) {
>>
>> Hello Roger, can this (pre-exis
On Mon, 5 May 2025 17:34:43 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactor to consistently use `isLatin1(coder)` within
>> AbstractStringBuilder.
>
> src/java.base/share/classes/java/lan
On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Fri, 2 May 2025 17:24:06 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Fri, 2 May 2025 17:24:06 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder,
>> and value buffers while the buffer capacity is being expanded and/or
>> inflated from Latin1 to UTF16 representations.
>> The refactoring pattern is to read and
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and write AbstractStringBuilder fields
> once using locals fo
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
Refactor AbstractStringBuilder to maintain consistency among count, coder, and
value buffers while the buffer capacity is being expanded and/or inflated from
Latin1 to UTF16 representations.
The refactoring pattern is to read and write AbstractStringBuilder fields once
using locals for all inte
55 matches
Mail list logo
