Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

2025-03-18 Thread Kim Barrett
On Mon, 17 Mar 2025 17:22:10 GMT, Kim Barrett wrote: >> Please review this revision of a previously puzzling comment intending to >> provide the rationale for a bit of non-obvious code. > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

2025-03-17 Thread Roger Riggs
On Mon, 17 Mar 2025 17:22:10 GMT, Kim Barrett wrote: >> Please review this revision of a previously puzzling comment intending to >> provide the rationale for a bit of non-obvious code. > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revisio

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

2025-03-17 Thread Kim Barrett
> Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Kim Barrett has updated the pull request incrementally with one additional commit since the last revision: bchristi-git review - Changes: - all: ht

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-13 Thread Brent Christian
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Changes requested by bchristi (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23952#pullr

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-13 Thread Brent Christian
On Wed, 12 Mar 2025 19:57:23 GMT, Kim Barrett wrote: >> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 142: >> >>> 140: // while there are registered cleanables for other >>> objects. >>> 141: // If the application cleans all remaining cleanab

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-12 Thread Kim Barrett
On Mon, 10 Mar 2025 23:14:23 GMT, Brent Christian wrote: >> Please review this revision of a previously puzzling comment intending to >> provide the rationale for a bit of non-obvious code. > > src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 142: > >> 140: // w

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-10 Thread Brent Christian
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 142: > 140: // while there ar

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-10 Thread Aleksey Shipilev
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Marked as reviewed by shade (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23952#pullreq

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-08 Thread Roger Riggs
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. Nice clear description. Thanks - Marked as reviewed by rriggs (Reviewer). PR Review: https://git.

RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-07 Thread Kim Barrett
Please review this revision of a previously puzzling comment intending to provide the rationale for a bit of non-obvious code. - Commit messages: - improve comment Changes: https://git.openjdk.org/jdk/pull/23952/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23952&range=00