Re: RFR: 8351000: StringBuilder getChar and putChar robustness [v2]

2025-04-30 Thread Lance Andersen
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote: >> Improve StringBuilder getChar and putChar robustness with racy updates to >> StringBuilder. >> Test racing threads with append, insert, and reading characters. > > Roger Riggs has updated the pull request incrementally with one additional

Re: RFR: 8351000: StringBuilder getChar and putChar robustness [v2]

2025-04-30 Thread Shaojin Wen
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote: >> Improve StringBuilder getChar and putChar robustness with racy updates to >> StringBuilder. >> Test racing threads with append, insert, and reading characters. > > Roger Riggs has updated the pull request incrementally with one additional

Re: RFR: 8351000: StringBuilder getChar and putChar robustness [v2]

2025-04-30 Thread Chen Liang
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote: >> Improve StringBuilder getChar and putChar robustness with racy updates to >> StringBuilder. >> Test racing threads with append, insert, and reading characters. > > Roger Riggs has updated the pull request incrementally with one additional

Re: RFR: 8351000: StringBuilder getChar and putChar robustness [v2]

2025-04-30 Thread Roger Riggs
> Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Test cleanup ---

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-30 Thread Andrey Turbanov
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. Let's cleanup test a bit - Changes requested by aturbanov (Committe

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-30 Thread Andrey Turbanov
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. test/jdk/java/lang/StringBuilder/RacingSBThreads.java line 61: > 59: // Cons

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Per Minborg
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. LGTM. Thanks for these improvements. - Marked as reviewed by pminbo

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Raffaello Giulietti
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. Looks fine. Thanks @RogerRiggs - Marked as reviewed by rgiulietti (

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Chen Liang
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. Thanks, other changes look good to me! - Marked as reviewed by liac

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Roger Riggs
On Tue, 29 Apr 2025 14:13:20 GMT, Chen Liang wrote: >> Improve StringBuilder getChar and putChar robustness with racy updates to >> StringBuilder. >> Test racing threads with append, insert, and reading characters. > > test/jdk/java/lang/StringBuilder/RacingSBThreads.java line 27: > >> 25: *

Re: RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Chen Liang
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote: > Improve StringBuilder getChar and putChar robustness with racy updates to > StringBuilder. > Test racing threads with append, insert, and reading characters. test/jdk/java/lang/StringBuilder/RacingSBThreads.java line 27: > 25: * @test >

RFR: 8351000: StringBuilder getChar and putChar robustness

2025-04-29 Thread Roger Riggs
Improve StringBuilder getChar and putChar robustness with racy updates to StringBuilder. Test racing threads with append, insert, and reading characters. - Commit messages: - 8351000: StringBuilder getChar and putChar robustness Changes: https://git.openjdk.org/jdk/pull/24951/file