Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-24 Thread Naoto Sato
On Wed, 23 Apr 2025 18:02:56 GMT, Stuart Marks wrote: >> * Windows and Unix: set sprops.stdin_encoding if connected to a console >> * Add specs for stdin.encoding >> * Adjust specs to change "undefined" to "unspecified" >> * Rewrite System.in spec to refer to new property and to clarify usage wit

Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 17:12:07 GMT, Stuart Marks wrote: >> I think the comment could be clearer. As I understand it, it's just trying >> to saying that the legacy sun.stdout.encoding/sun.stderr.encoding properties >> for stdout/stderr only, no equivalent for stdin. > > Yeah the comment was a bit

Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-23 Thread Stuart Marks
> * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with > classes that perform encoding > * Update property test

Re: RFR: 8350703: Add standard system property stdin.encoding [v3]

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 18:02:56 GMT, Stuart Marks wrote: >> * Windows and Unix: set sprops.stdin_encoding if connected to a console >> * Add specs for stdin.encoding >> * Adjust specs to change "undefined" to "unspecified" >> * Rewrite System.in spec to refer to new property and to clarify usage wit

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Stuart Marks
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote: > * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with >

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
On Wed, 23 Apr 2025 01:34:42 GMT, Naoto Sato wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update sun.stdout/err.encoding comments; tweak Windows file handle >> variable name. > > src/java.base/windows/native/li

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
> * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with > classes that perform encoding > * Update property test

Re: RFR: 8350703: Add standard system property stdin.encoding [v2]

2025-04-23 Thread Stuart Marks
On Wed, 23 Apr 2025 12:54:29 GMT, Alan Bateman wrote: >> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 92: >> >>> 90: >>> 91: // Encoding properties for stdin, stdout, and stderr. For >>> stdout and stderr, >>> 92: // check "sun.*.encoding" properties befo

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Alan Bateman
On Wed, 23 Apr 2025 01:33:39 GMT, Naoto Sato wrote: >> * Windows and Unix: set sprops.stdin_encoding if connected to a console >> * Add specs for stdin.encoding >> * Adjust specs to change "undefined" to "unspecified" >> * Rewrite System.in spec to refer to new property and to clarify usage with

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-23 Thread Alan Bateman
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote: > * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with >

Re: RFR: 8350703: Add standard system property stdin.encoding

2025-04-22 Thread Naoto Sato
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote: > * Windows and Unix: set sprops.stdin_encoding if connected to a console > * Add specs for stdin.encoding > * Adjust specs to change "undefined" to "unspecified" > * Rewrite System.in spec to refer to new property and to clarify usage with >

RFR: 8350703: Add standard system property stdin.encoding

2025-04-22 Thread Stuart Marks
* Windows and Unix: set sprops.stdin_encoding if connected to a console * Add specs for stdin.encoding * Adjust specs to change "undefined" to "unspecified" * Rewrite System.in spec to refer to new property and to clarify usage with classes that perform encoding * Update property test ---