Re: RFR: 8350041: Make libstringPlatformChars support static JDK [v3]

2025-02-21 Thread Jiangli Zhou
> Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.h"` and don't link `libstringPlatformChars.so` > with `

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-20 Thread Alan Bateman
On Thu, 20 Feb 2025 23:44:44 GMT, Jiangli Zhou wrote: > Updated to skipping > `java/lang/String/nativeEncoding/StringPlatformChars.java` on static JDK. Thanks. If you can bump the copyright header date then I think we are done with this one. - PR Comment: https://git.openjdk.org/

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-20 Thread Jiangli Zhou
On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou wrote: > Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.

Re: RFR: 8350041: Make libstringPlatformChars support static JDK [v2]

2025-02-20 Thread Jiangli Zhou
> Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.h"` and don't link `libstringPlatformChars.so` > with `

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-18 Thread Jiangli Zhou
On Tue, 18 Feb 2025 17:05:06 GMT, Alan Bateman wrote: > I don't object to changing this test but it might be simpler to just skip > this test, once we can use `@requires !jdk.static`. Thanks, @AlanBateman. I think skipping this test for static JDK sounds reasonable to me, since this test seems

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-18 Thread Alan Bateman
On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou wrote: > Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.

RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-14 Thread Jiangli Zhou
Please review the fix to make `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and `JNU_NewStringPlatform` dynamically - Remove `#include "jni_util.h"` and don't link `libstringPlatformChars.so` with `libjava.so` -