Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v3]

2025-04-16 Thread Hao Sun
On Thu, 17 Apr 2025 03:13:05 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v3]

2025-04-16 Thread Chen Liang
On Thu, 17 Apr 2025 03:13:05 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v3]

2025-04-16 Thread Nicole Xu
> The UnsafeOps JMH benchmark fails with the following error: > > ``` > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in module java.base) because module > java.base does not

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v3]

2025-04-16 Thread Liam Miller-Cushon
On Thu, 17 Apr 2025 03:37:03 GMT, Hao Sun wrote: > I was wondering if `--disable-java-warnings-as-errors` could help to address > your concern about this PR. It doesn't address the issue unless it's configured by default, which I don't think is being proposed. I think the best approach would b

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-04-10 Thread Nicole Xu
On Thu, 27 Feb 2025 03:22:27 GMT, Nicole Xu wrote: > Would it be possible to configure the build of the microbenchmarks to not > pass `-Werror`, so they don't break when sunapi diagnostics are emitted? > > > Note that even it will raise "proprietary API" warnings after this patch, > > it is ac

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-04-01 Thread Chen Liang
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-03-31 Thread Liam Miller-Cushon
On Fri, 28 Mar 2025 09:26:45 GMT, Alan Bateman wrote: > > @AlanBateman Can you review this if this patch looks good in principle? > > It needs confirmation that it doesn't break the build, I haven't looked into > which parts of Liam's change weren't backed out. So if there are no build > issue

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-03-28 Thread Alan Bateman
On Fri, 21 Feb 2025 07:10:16 GMT, Alan Bateman wrote: >> Nicole Xu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8349944: [JMH] sun.misc.UnsafeOps cannot access class >> jdk.internal.misc.Unsafe >> >>The UnsafeOps JMH benchm

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-03-27 Thread Chen Liang
On Fri, 21 Feb 2025 07:10:16 GMT, Alan Bateman wrote: >> Nicole Xu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8349944: [JMH] sun.misc.UnsafeOps cannot access class >> jdk.internal.misc.Unsafe >> >>The UnsafeOps JMH benchm

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-26 Thread Chen Liang
On Wed, 26 Feb 2025 12:13:59 GMT, Liam Miller-Cushon wrote: >> Nicole Xu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8349944: [JMH] sun.misc.UnsafeOps cannot access class >> jdk.internal.misc.Unsafe >> >>The UnsafeOps JMH

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-26 Thread Nicole Xu
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-26 Thread Liam Miller-Cushon
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-25 Thread Nicole Xu
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> ``` >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-20 Thread Nicole Xu
On Fri, 21 Feb 2025 07:10:16 GMT, Alan Bateman wrote: > Thanks for restoring, this micro was specifically for sun.misc.Unsafe. I'm > not wondering about the FFM micros that were also changed by JDK-8332744. > Might not matter there but I think the original motive was to compare against > sun.m

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-20 Thread Alan Bateman
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote: >> The UnsafeOps JMH benchmark fails with the following error: >> >> java.lang.IllegalAccessError: class >> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot >> access class jdk.internal.misc.Unsafe (in module j

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe [v2]

2025-02-20 Thread Nicole Xu
> The UnsafeOps JMH benchmark fails with the following error: > > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in module java.base) because module > java.base does not export jdk.

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-02-19 Thread Chen Liang
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote: > The UnsafeOps JMH benchmark fails with the following error: > > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in module java.b

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-02-19 Thread Alan Bateman
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote: > The UnsafeOps JMH benchmark fails with the following error: > > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in module java.b

Re: RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-02-19 Thread Nicole Xu
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote: > The UnsafeOps JMH benchmark fails with the following error: > > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in module java.b

RFR: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-02-19 Thread Nicole Xu
The UnsafeOps JMH benchmark fails with the following error: java.lang.IllegalAccessError: class org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot access class jdk.internal.misc.Unsafe (in module java.base) because module java.base does not export jdk.internal.mis