On Tue, 18 Feb 2025 19:29:10 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Tue, 18 Feb 2025 19:29:10 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Wed, 19 Feb 2025 21:05:47 GMT, Jiangli Zhou wrote:
> * No `jlink` tool in `static-jdk` when running on static JDK. This is
> currently observable using the `static-jdk`.
> * No separate `lib/modules` file (and other JDK resource files) if we build a
> single hermetic Java image for the test.
On Wed, 19 Feb 2025 07:33:02 GMT, Alan Bateman wrote:
> > This part however feels odd. Updating this (and other tests in future) to
> > use the `@requires !jdk.static` to identify the presence or absence of a
> > specific tool in the JDK installation doesn't seem right. Perhaps they
> > should
On Wed, 19 Feb 2025 06:54:50 GMT, Jaikiran Pai wrote:
> On a more general note, is it a goal to have the static JDK build run against
> all these tests that are part of the JDK repo? Would that mean that a lot of
> these will have to start using `@requires` to accomodate this?
Running static J
On Wed, 19 Feb 2025 06:54:50 GMT, Jaikiran Pai wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> On a more general note, is it a goal to have the
On Wed, 19 Feb 2025 06:50:33 GMT, Jaikiran Pai wrote:
> This part however feels odd. Updating this (and other tests in future) to use
> the `@requires !jdk.static` to identify the presence or absence of a specific
> tool in the JDK installation doesn't seem right. Perhaps they should instead
>
On Tue, 18 Feb 2025 19:29:10 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Tue, 18 Feb 2025 19:29:10 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Wed, 19 Feb 2025 00:06:52 GMT, Man Cao wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since
On Tue, 18 Feb 2025 19:26:09 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Tue, 18 Feb 2025 19:29:10 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
> Please review this change that adds the `jdk.static` VMProps. It can be used
> to skip tests not for running on static JDK.
>
> This also adds a new WhiteBox native method,
> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to
> determine if it's static at runtime.
>
> `@re
On Tue, 11 Feb 2025 08:10:24 GMT, Alan Bateman wrote:
>> I think this looks okay, I'm just wondering is one property is enough to
>> cover all the configurations.
>
>> Thanks, @AlanBateman.
>>
>> > I'm just wondering is one property is enough to cover all the
>> > configurations.
>>
>> +1
>>
On Tue, 18 Feb 2025 19:09:00 GMT, Jiangli Zhou wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
> Please review this change that adds the `jdk.static` VMProps. It can be used
> to skip tests not for running on static JDK.
>
> This also adds a new WhiteBox native method,
> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to
> determine if it's static at runtime.
>
> `@re
On Tue, 11 Feb 2025 08:10:24 GMT, Alan Bateman wrote:
> That's okay with me. I'm hoping Magnus will jump in when he gets a chance as
> he has experience with the "other" static build configurations.
@magicus Any thoughts and input on this?
-
PR Comment: https://git.openjdk.org/jdk
On Mon, 10 Feb 2025 08:21:21 GMT, Alan Bateman wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Mon, 10 Feb 2025 08:21:21 GMT, Alan Bateman wrote:
>> Please review this change that adds the `jdk.static` VMProps. It can be used
>> to skip tests not for running on static JDK.
>>
>> This also adds a new WhiteBox native method,
>> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by
On Fri, 7 Feb 2025 23:51:41 GMT, Jiangli Zhou wrote:
> Please review this change that adds the `jdk.static` VMProps. It can be used
> to skip tests not for running on static JDK.
>
> This also adds a new WhiteBox native method,
> `jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProp
Please review this change that adds the `jdk.static` VMProps. It can be used to
skip tests not for running on static JDK.
This also adds a new WhiteBox native method,
`jdk.test.whitebox.WhiteBox.isStatic()`, which is used by VMProps to determine
if it's static at runtime.
`@requires !jdk.stat
21 matches
Mail list logo
