Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope [v2]

2025-03-05 Thread Alan Bateman
On Thu, 6 Mar 2025 02:56:34 GMT, SendaoYan wrote: >> Hi all, >> >> Several JMH tests fails "cannot access class >> jdk.internal.vm.ContinuationScope (in module java.base) because module >> java.base does not export jdk.internal.vm to unnamed module". This PR add VM >> option `--add-exports=ja

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-03-05 Thread SendaoYan
On Wed, 5 Mar 2025 16:15:55 GMT, Alan Bateman wrote: >> Should we remove these JMH tests, or just fix the test bug and make tests >> run normally > >> Should we remove these JMH tests, or just fix the test bug and make tests >> run normally > > I think that would be best as they are left over

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-03-05 Thread SendaoYan
On Wed, 5 Mar 2025 16:15:55 GMT, Alan Bateman wrote: > > Should we remove these JMH tests, or just fix the test bug and make tests > > run normally > > I think that would be best as they are left over from early development. The related test files has been removed in this PR. - P

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope [v2]

2025-03-05 Thread SendaoYan
> Hi all, > > Several JMH tests fails "cannot access class > jdk.internal.vm.ContinuationScope (in module java.base) because module > java.base does not export jdk.internal.vm to unnamed module". This PR add VM > option `--add-exports=java.base/jdk.internal.vm=ALL-UNNAMED` to fix the JMH > tes

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-03-05 Thread Alan Bateman
On Tue, 4 Mar 2025 15:33:16 GMT, SendaoYan wrote: > Should we remove these JMH tests, or just fix the test bug and make tests run > normally I think that would be best as they are left over from early development. - PR Comment: https://git.openjdk.org/jdk/pull/23437#issuecomment-2

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-03-04 Thread SendaoYan
On Tue, 4 Feb 2025 12:35:50 GMT, SendaoYan wrote: > Hi all, > > Several JMH tests fails "cannot access class > jdk.internal.vm.ContinuationScope (in module java.base) because module > java.base does not export jdk.internal.vm to unnamed module". This PR add VM > option `--add-exports=java.bas

Re: RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-02-04 Thread Alan Bateman
On Tue, 4 Feb 2025 12:35:50 GMT, SendaoYan wrote: > Hi all, > > Several JMH tests fails "cannot access class > jdk.internal.vm.ContinuationScope (in module java.base) because module > java.base does not export jdk.internal.vm to unnamed module". This PR add VM > option `--add-exports=java.bas

RFR: 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

2025-02-04 Thread SendaoYan
Hi all, Several JMH tests fails "cannot access class jdk.internal.vm.ContinuationScope (in module java.base) because module java.base does not export jdk.internal.vm to unnamed module". This PR add VM option `--add-exports=java.base/jdk.internal.vm=ALL-UNNAMED` to fix the JMH test bug. Change