On Tue, 28 Jan 2025 22:56:51 GMT, Jiangli Zhou wrote:
> Is the actual change addressing the compilation issue in closed repo?
Yes.
> If so, is it to properly add -Zc:preprocessor?
No. The fix was to add missing `DEF_STATIC_JNI_OnLoad` define.
-
PR Comment: https://git.openjdk.org
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
Marked as reviewed by jiangli (Reviewer).
Looks good.
@alexeysemenyukoracle, Is the actual change addressing the compilation issue in
closed repo? If so, is it to prop
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
@jianglizhou, @jerboaa, @kevinrushforth please review. This PR will be
integrated after integrating a patch to the closed Oracle JDK build so it will
not result in the
On Tue, 28 Jan 2025 22:42:00 GMT, Alexey Semenyuk wrote:
> Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
This looks good. I confirm that this is the correct backout patch
for[JDK-834](https://bugs.openjdk.org/browse/JDK-834), thus resotring
the fix for[JDK-8348348]
Reapply [JDK-8348348](https://bugs.openjdk.org/browse/JDK-8348348)
-
Commit messages:
- JDK-8348892: Properly fix compilation error for zip_util.c on Windows
Changes: https://git.openjdk.org/jdk/pull/23344/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23344&range=00
Iss
