Re: RFR: 8348870: Eliminate array bound checks in DecimalDigits

2025-01-28 Thread Raffaello Giulietti
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote: > Expand DIGITS length to 128 and eliminate array bounds checking by using & > 0x7F when accessing DIGITS Marked as reviewed by rgiulietti (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23335#pullrequestreview-2579409

Re: RFR: 8348870: Eliminate array bound checks in DecimalDigits

2025-01-28 Thread Chen Liang
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote: > Expand DIGITS length to 128 and eliminate array bounds checking by using & > 0x7F when accessing DIGITS Ran tests tier 1-3, no failure besides a known serviceability one. - PR Comment: https://git.openjdk.org/jdk/pull/23335#is

Re: RFR: 8348870: Eliminate array bound checks in DecimalDigits

2025-01-28 Thread Chen Liang
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote: > Expand DIGITS length to 128 and eliminate array bounds checking by using & > 0x7F when accessing DIGITS Simple optimization, unfortunately this is a nice feature of the JVM not properly exposed in the language or libraries. -

Re: RFR: 8348870: Eliminate array bound checks in DecimalDigits

2025-01-28 Thread Chen Liang
On Tue, 28 Jan 2025 14:49:45 GMT, Shaojin Wen wrote: > Expand DIGITS length to 128 and eliminate array bounds checking by using & > 0x7F when accessing DIGITS Can we rename this to have a more descriptive title, like "Eliminate array bound checks in DecimalDigits"? - PR Comment: