On Wed, 29 Jan 2025 18:35:31 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Wed, 29 Jan 2025 18:35:31 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Wed, 29 Jan 2025 18:35:31 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains n
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Thu, 23 Jan 2025 02:50:46 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request with a new target base
On Thu, 23 Jan 2025 02:47:00 GMT, Justin Lu wrote:
>> How about I revert the most recent commit and have this PR simply deliver
>> the change to provide the stream of currencies. I'll file another issue to
>> improve `available` to use stable values when that is available. Does that
>> sound f
On Wed, 22 Jan 2025 18:37:32 GMT, Justin Lu wrote:
>> I'm not sure how useful it is to optimize the performance of
>> `availableCurrencies` access to "available", but adding volatile will slow
>> every access down.
>> The computation of the available currencies is stable, so a race computing
>
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes
On Wed, 22 Jan 2025 17:09:54 GMT, Roger Riggs wrote:
>> Thanks Chen, made `available` volatile and implemented DCL in
>> https://github.com/openjdk/jdk/pull/23165/commits/96e86c800f1d1af1c20bfee944c298f17b7e8860.
>> Also added a duplicate elements test as you suggested.
>
> I'm not sure how usef
On Tue, 21 Jan 2025 18:44:39 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/Currency.java line 469:
>>
>>> 467:
>>> 468: // Initialize the set of available currencies if needed
>>> 469: private static synchronized void initAvailableCurrencies() {
>>
>> Should we make `a
On Sat, 18 Jan 2025 01:29:01 GMT, Chen Liang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provide message for test assertion
>
> src/java.base/share/classes/java/util/Currency.java line 469:
>
>> 467:
>> 468:
On Mon, 20 Jan 2025 09:46:05 GMT, Viktor Klang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provide message for test assertion
>
> src/java.base/share/classes/java/util/Currency.java line 494:
>
>> 492:
>> 493:
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect feedb
On Fri, 17 Jan 2025 23:33:50 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 17 Jan 2025 23:33:50 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 17 Jan 2025 23:33:50 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
provide messa
On Fri, 17 Jan 2025 23:10:54 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 17 Jan 2025 22:49:07 GMT, Roger Riggs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> init hashset w/ accurate size via HashSet.newHashSet(int)
>
> src/java.base/share/classes/java/util/Currency.java line 439:
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect Roger
On Fri, 17 Jan 2025 22:39:14 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 17 Jan 2025 22:11:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> synchronize init method over block
>
> src/java.base/share/classes/java/util/Currency.java line 467:
>
>> 465: private
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
init hashset
On Thu, 16 Jan 2025 22:39:52 GMT, Justin Lu wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one
> Please review this PR and CSR which adds a method to _java.util.Currency_
> which returns a stream of the available Currencies.
>
> The motivation can be found in the CSR.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
synchronize i
Please review this PR and CSR which adds a method to _java.util.Currency_ which
returns a stream of the available Currencies.
The motivation can be found in the CSR.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/23165/files
Webrev: https://webrevs.openjdk.o
28 matches
Mail list logo
