Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-12 Thread Alan Bateman
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed jdk.internal package prefix from asm > > Thanks for the reviews. I'll update the copyright years and run again ti

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-10 Thread Magnus Ihse Bursie
On Fri, 10 Jan 2025 15:39:20 GMT, Adam Sotona wrote: > Jtreg seems to have no problems to use ASM as a declared library. Whan you say "no problems", I guess you are referring to the pass rate of the tests. But how does it affect the runtime spent doing testing? I must insist that "just moving"

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-10 Thread Adam Sotona
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-10 Thread Magnus Ihse Bursie
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Leonid Mesnik
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Alan Bateman
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Alan Bateman
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Andrey Turbanov
On Thu, 9 Jan 2025 08:40:37 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam S

Re: RFR: 8346986: Remove ASM from java.base [v3]

2025-01-09 Thread Adam Sotona
> There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additio