Re: RFR: 8346884: Add since checker test to jdk.editpad

2025-07-09 Thread Nizar Benalla
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote: > Please review this patch to add a new test to check `@since` tags in the > `jdk.editpad` module. > > TIA Thanks for the review Jaikiran. This passes on all platforms in our CI - PR Comment: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8346884: Add since checker test to jdk.editpad

2025-07-07 Thread Jaikiran Pai
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote: > Please review this patch to add a new test to check `@since` tags in the > `jdk.editpad` module. > > TIA This looks OK to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25613#pullre

Re: RFR: 8346884: Add since checker test to jdk.editpad

2025-07-01 Thread Nizar Benalla
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote: > Please review this patch to add a new test to check `@since` tags in the > `jdk.editpad` module. > > TIA keep alive - PR Comment: https://git.openjdk.org/jdk/pull/25613#issuecomment-3023556036

Re: RFR: 8346884: Add since checker test to jdk.editpad

2025-06-03 Thread Nizar Benalla
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote: > Please review this patch to add a new test to check `@since` tags in the > `jdk.editpad` module. > > TIA I realize there are no classfiles in `jdk.editpad` but the test can also check the `@since` information in the `module-info.java` fi

RFR: 8346884: Add since checker test to jdk.editpad

2025-06-03 Thread Nizar Benalla
Please review this patch to add a new test to check `@since` tags in the `jdk.editpad` module. TIA - Commit messages: - add new `@since` test Changes: https://git.openjdk.org/jdk/pull/25613/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25613&range=00 Issue: https://bu