Re: [jdk24] RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-08 Thread Alexander Matveev
On Wed, 8 Jan 2025 22:09:29 GMT, Alexey Semenyuk wrote: > Clean backport to jdk24 Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22982#pullrequestreview-2538406774

[jdk24] RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-08 Thread Alexey Semenyuk
Clean backport to jdk24 - Commit messages: - Backport 4d18e5a1e26e04beb550d01ba5a3dbb8c0c37fa0 Changes: https://git.openjdk.org/jdk/pull/22982/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22982&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346872 Stats: 25 lin

Re: [jdk24] RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-08 Thread Alexey Semenyuk
On Wed, 8 Jan 2025 22:09:29 GMT, Alexey Semenyuk wrote: > Clean backport to jdk24 @sashamatveev PTAL - PR Comment: https://git.openjdk.org/jdk/pull/22982#issuecomment-2578773249

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v3]

2025-01-08 Thread Alexey Semenyuk
On Fri, 3 Jan 2025 21:33:17 GMT, Alexey Semenyuk wrote: >> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the >> test's work directory doesn't support DOS file names. > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. Th

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v3]

2025-01-08 Thread Matthias Baesken
On Fri, 3 Jan 2025 21:33:17 GMT, Alexey Semenyuk wrote: >> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the >> test's work directory doesn't support DOS file names. > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. Th

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v3]

2025-01-03 Thread Alexander Matveev
On Fri, 3 Jan 2025 21:33:17 GMT, Alexey Semenyuk wrote: >> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the >> test's work directory doesn't support DOS file names. > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. Th

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v2]

2025-01-03 Thread Alexey Semenyuk
On Fri, 3 Jan 2025 21:30:02 GMT, Alexander Matveev wrote: > What I mean is what will happen if following command run manually by user > from terminal without DOS file names support If file conversion fails, jpackage will show `Failed to get short version of path` error message, where `` is an

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v3]

2025-01-03 Thread Alexey Semenyuk
> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in b

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v2]

2025-01-03 Thread Alexander Matveev
On Fri, 3 Jan 2025 14:39:53 GMT, Alexey Semenyuk wrote: >> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the >> test's work directory doesn't support DOS file names. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the la

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-03 Thread Alexey Semenyuk
On Thu, 2 Jan 2025 23:58:29 GMT, Alexander Matveev wrote: > Did you check behavior of jpackage when it is executed without support for > DOS file names from command line by user? Yes, I did. But I ran it without jtreg and didn't catch missing `@library /test/lib`. > For example what error me

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails [v2]

2025-01-03 Thread Alexey Semenyuk
> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision: Add missing `@library /test/lib` and update copyr

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-03 Thread Alexey Semenyuk
On Fri, 3 Jan 2025 08:05:11 GMT, Matthias Baesken wrote: > Maybe you need now > * @library /test/lib > > too ? Yes. This was the missing part - PR Comment: https://git.openjdk.org/jdk/pull/22896#issuecomment-2569314321

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-03 Thread Matthias Baesken
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote: > Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. After adding it to our build/test queue, this fails with #section:build --messages:(3/144)-

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-02 Thread Alexander Matveev
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote: > Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. Looks good. Did you check behavior of jpackage when it is executed without support for DOS file names fr

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2025-01-02 Thread Matthias Baesken
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote: > Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. > alexeysemenyukoracle I added the patch to our build/test queue . - PR Comment: https://g

Re: RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2024-12-30 Thread Alexey Semenyuk
On Mon, 30 Dec 2024 21:25:20 GMT, Alexey Semenyuk wrote: > Skip the test (throw `jtreg.SkippedException`) if the volume that owns the > test's work directory doesn't support DOS file names. @MBaesken please try the fix in your test environment. - PR Comment: https://git.openjdk.or

RFR: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

2024-12-30 Thread Alexey Semenyuk
Skip the test (throw `jtreg.SkippedException`) if the volume that owns the test's work directory doesn't support DOS file names. - Commit messages: - 8346872: tools/jpackage/windows/WinLongPathTest.java fails Changes: https://git.openjdk.org/jdk/pull/22896/files Webrev: https://w