On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Fri, 20 Dec 2024 07:53:07 GMT, Matthias Baesken wrote:
>> Please review this fairly simple change to improve how the
>> `JimageDiffGenerator` works. The original implementation is pretty naive and
>> read all bytes into memory and then compared them. This improved version
>> only reads byte
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Fri, 20 Dec 2024 07:53:07 GMT, Matthias Baesken wrote:
> Hi Severin, I added it to our build/test queue.
Thanks, Matthias!
-
PR Comment: https://git.openjdk.org/jdk/pull/22835#issuecomment-2556610466
On Fri, 20 Dec 2024 02:12:27 GMT, Fei Yang wrote:
> Yes, I can confirm that it works on my linux-aarch64 platform. Great! Thanks!
Thank you!
-
PR Comment: https://git.openjdk.org/jdk/pull/22835#issuecomment-2556609682
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Thu, 19 Dec 2024 18:16:47 GMT, Severin Gehwolf wrote:
> @MBaesken @RealFYang Could you please test this PR since you originally ran
> into JDK-8346239 (this bug) and
> [JDK-8344036](https://bugs.openjdk.org/browse/JDK-8344036). Thanks!
Yes, I can confirm that it works on my linux-aarch64 pl
On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
Please review this fairly simple change to improve how the
`JimageDiffGenerator` works. The original implementation is pretty naive and
read all bytes into memory and then compared them. This improved version only
reads bytes on a bound buffer into memory compares those bytes and if equal
conti
14 matches
Mail list logo
