On Tue, 17 Dec 2024 08:04:17 GMT, Alan Bateman wrote:
>> Thank you Lance for the review. Alan, is it OK to proceed with this current
>> change or do you think we should pursue the `REPLACE_EXISTING` option here?
>
> I don't object to what you have, it's the mixing of old and new APIs that
> jum
On Tue, 17 Dec 2024 04:05:36 GMT, Jaikiran Pai wrote:
>> Hello Alan, I had thought about that, but then I looked at the
>> implementation of `Files.copy(...)` with `REPLACE_EXISTING`. If that option
>> is specified, the `Files.copy(...)` implementation first deletes the
>> existing file:
>>
>
On Fri, 13 Dec 2024 13:41:52 GMT, Jaikiran Pai wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 435:
>>
>>> 433: file = createTemporaryFile("tmpJar", ".jar");
>>> 434: try (InputStream in = new
>>> FileInputStream(FileDescriptor.in)) {
On Mon, 16 Dec 2024 15:15:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>>
>> The `jar` tool has several operations which take `--file` as a parameter.
>> The value for tha
> Can I please get a review of this change which proposes to address the issue
> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>
> The `jar` tool has several operations which take `--file` as a parameter. The
> value for that option is a JAR file path. The `jar` operation is then run
On Fri, 13 Dec 2024 13:31:01 GMT, Alan Bateman wrote:
>> Can I please get a review of this change which proposes to address the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>>
>> The `jar` tool has several operations which take `--file` as a parameter.
>> The value for tha
On Fri, 13 Dec 2024 13:17:39 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>
> The `jar` tool has several operations which take `--file` as a parameter. The
> value for that opt
Can I please get a review of this change which proposes to address the issue
reported in https://bugs.openjdk.org/browse/JDK-8345506?
The `jar` tool has several operations which take `--file` as a parameter. The
value for that option is a JAR file path. The `jar` operation is then run
against t
