Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted [v2]

2024-12-09 Thread Severin Gehwolf
> Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > the command line. For JDK builds with JEP 493 enabled, the `

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-09 Thread Severin Gehwolf
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Mandy Chung
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 09:31:21 GMT, Severin Gehwolf wrote: > > Just to double check, with the default build, then `jlink --add-modules > > ALL-MODULE-PATH --output myimage` would fail because the module path hasn't > > been specified. No difference between default and > > --generate-linkable-runt

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Severin Gehwolf
On Thu, 5 Dec 2024 14:39:58 GMT, Alan Bateman wrote: > > Abort the link with an appropriate error when ALL-MODULE-PATH is being used > > and a link from the run-time image is used but no module path given > > (--module-path arg missing). > > Just to double check, with the default build, then `

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-05 Thread Alan Bateman
On Tue, 3 Dec 2024 18:51:04 GMT, Severin Gehwolf wrote: > Abort the link with an appropriate error when ALL-MODULE-PATH is being used > and a link from the run-time image is used but no module path given > (--module-path arg missing). Just to double check, with the default build, then `jlink -

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-03 Thread Mandy Chung
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-03 Thread Severin Gehwolf
On Tue, 3 Dec 2024 18:01:18 GMT, Mandy Chung wrote: > > ALL-MODULE-PATH means all observable modules on the module path but here, > > it's all observable modules minus jdk.jlink or any module that directly > > requires jdk.jlink. This is hard to reason about, and not exactly right > > either b

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-03 Thread Mandy Chung
On Tue, 3 Dec 2024 15:26:32 GMT, Alan Bateman wrote: > ALL-MODULE-PATH means all observable modules on the module path but here, > it's all observable modules minus jdk.jlink or any module that directly > requires jdk.jlink. This is hard to reason about, and not exactly right > either because

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-03 Thread Severin Gehwolf
On Tue, 3 Dec 2024 15:26:32 GMT, Alan Bateman wrote: > I'm in two minds as to whether we should do anything here. So am I. The main motivation is that this no longer works with JEP 493 is enabled (no `jmods` dir): $ bin/jlink --add-modules ALL-MODULE-PATH --output all-mods Without looking a

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-03 Thread Alan Bateman
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-02 Thread Severin Gehwolf
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-02 Thread Severin Gehwolf
Please review this bug fix for using `jlink` when linking from the run-time image. For regular JDK builds which include the `jmods` folder, that path is automatically added as the `--module-path` when not otherwise specified on the command line. For JDK builds with JEP 493 enabled, the `jmods` f