Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-07 Thread Joe Wang
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-07 Thread Zheng Feng
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-07 Thread Severin Gehwolf
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Iris Clark
On Thu, 6 Feb 2025 20:19:53 GMT, Joe Wang wrote: >> Fix an issue where the translet-name is incorrectly set when the >> package-name is also specified. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update test Marked as rev

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Lance Andersen
On Thu, 6 Feb 2025 20:19:53 GMT, Joe Wang wrote: >> Fix an issue where the translet-name is incorrectly set when the >> package-name is also specified. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update test Marked as rev

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
> Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update test - Changes: - all: https://git.openjdk.org/jdk/pull/23446/fil

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
On Thu, 6 Feb 2025 17:58:08 GMT, Severin Gehwolf wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test > > test/jaxp/javax/xml/jaxp/unittest/transform/PropertiesTest.java line 94: > >> 92: >> 93: if (ge

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
On Thu, 6 Feb 2025 18:04:47 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test > > test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java line 33: > >> 31: public static final Strin

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-06 Thread Naoto Sato
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote: > Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. Marked as reviewed by naoto (Reviewer). test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java line 33: > 31: public static final St

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-06 Thread Severin Gehwolf
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote: > Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. test/jaxp/javax/xml/jaxp/unittest/transform/PropertiesTest.java line 94: > 92: > 93: if (generateTranslet) { > 94: //Files.

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-06 Thread Lance Andersen
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote: > Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23446#pullrequestreview-2599444141

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-05 Thread Joe Wang
On Wed, 5 Feb 2025 10:57:14 GMT, Severin Gehwolf wrote: > > @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425? > > Just mentioning since it looks like a duplicate proposal. Indeed, I missed that. The right procedure to take over an issue is to ask the person assigned to the bu

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-05 Thread Joe Wang
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-05 Thread Severin Gehwolf
On Wed, 5 Feb 2025 10:47:27 GMT, Severin Gehwolf wrote: > @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425? Just mentioning since it looks like a duplicate proposal. - PR Comment: https://git.openjdk.org/jdk/pull/23446#issuecomment-2636402802

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-05 Thread Severin Gehwolf
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote: > Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425? - PR Comment: https://git.openjdk.org/jdk/pull/23446#issuecomme

RFR: 8344925: translet-name ignored when package-name is also set

2025-02-04 Thread Joe Wang
Fix an issue where the translet-name is incorrectly set when the package-name is also specified. - Commit messages: - update copyright - 8344925: translet-name ignored when package-name is also set Changes: https://git.openjdk.org/jdk/pull/23446/files Webrev: https://webrevs.ope

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-01-23 Thread Severin Gehwolf
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-01-23 Thread Zheng Feng
…String) This bug seems from the improper handling of package and class name initialization in `XSLTC` since there is a default value of `_packageName` with `die.verwandlung`. This fix is just adjusting to call `setPackageName` before `setClassName`. I've done the tire1 and tire2 tests. The t

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-01-23 Thread Zheng Feng
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >