Re: RFR: 8344770: Switch jpackage unit tests to use JUnit5 [v2]

2024-11-26 Thread Alexander Matveev
On Wed, 27 Nov 2024 01:27:15 GMT, Alexey Semenyuk wrote: >> Switched jpackage unit tests to use JUnit5. >> Got rid of dependencies on the "hamcrest". > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelate

Re: RFR: 8344770: Switch jpackage unit tests to use JUnit5 [v2]

2024-11-26 Thread Alexey Semenyuk
On Thu, 21 Nov 2024 23:53:59 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional

Re: RFR: 8344770: Switch jpackage unit tests to use JUnit5 [v2]

2024-11-26 Thread Alexey Semenyuk
> Switched jpackage unit tests to use JUnit5. > Got rid of dependencies on the "hamcrest". Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contai

Re: RFR: 8344770: Switch jpackage unit tests to use JUnit5

2024-11-21 Thread Alexander Matveev
On Thu, 21 Nov 2024 18:35:56 GMT, Alexey Semenyuk wrote: > Switched jpackage unit tests to use JUnit5. > Got rid of dependencies on the "hamcrest". Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22302#pullrequestreview-24530262

Re: RFR: 8344770: Switch jpackage unit tests to use JUnit5

2024-11-21 Thread Alexey Semenyuk
On Thu, 21 Nov 2024 18:35:56 GMT, Alexey Semenyuk wrote: > Switched jpackage unit tests to use JUnit5. > Got rid of dependencies on the "hamcrest". @sashamatveev ptal - PR Comment: https://git.openjdk.org/jdk/pull/22302#issuecomment-2492126711

RFR: 8344770: Switch jpackage unit tests to use JUnit5

2024-11-21 Thread Alexey Semenyuk
Switched jpackage unit tests to use JUnit5. Got rid of dependencies on the "hamcrest". - Commit messages: - All tests pass - Merge branch 'master' into JDK-8333571 - Copyright year update - Run `bin/blessed-modifier-order.sh` script - 8333571: Replace ExpectedException with asser