Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Jan Lahoda
On Tue, 29 Apr 2025 10:13:39 GMT, Maurizio Cimadamore wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 345: >> >>> 343: boolean hasModuleImports = source == null || >>> 344: >>> Feature.MODULE_IMPORTS.allowedInSource(s

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Jan Lahoda
On Tue, 29 Apr 2025 10:23:26 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - Merge branch 'master' into JDK-8344708 >> - Adjusting ToolProviderTest to the update

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Tue, 29 Apr 2025 10:12:07 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - Merge branch 'master' into JDK-8344708 >> - Adjusting ToolProviderTest to the update

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-28 Thread Vicente Romero
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-28 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'master' into JDK-8344708 - Ad