Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-21 Thread Abdelhak Zaaim
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344659: System.getPropert

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-21 Thread Daniel Fuchs
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344659: System.getPropert

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-21 Thread Lance Andersen
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344659: System.getPropert

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-20 Thread Iris Clark
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344659: System.getPropert

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-20 Thread Roger Riggs
On Thu, 21 Nov 2024 01:45:56 GMT, Brian Burkhalter wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344659: System.getPropert

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-20 Thread Brian Burkhalter
> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and > #22132. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8344659: System.getProperty("sun.jnu.encoding") -> StaticProperty.jnuEncoding() -

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio [v2]

2024-11-20 Thread Brian Burkhalter
On Wed, 20 Nov 2024 23:34:22 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8344659: System.getProperty("sun.jnu.encoding") -> >> StaticProperty.jnuEncoding() > > src/java.base/share/classes/s

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio

2024-11-20 Thread Brian Burkhalter
On Wed, 20 Nov 2024 23:14:30 GMT, Lance Andersen wrote: >> Remove some occurrences of `GetPropertyAction` overlooked in #22219 and >> #22132. > > LGTM @LanceAndersen , @naotoj Thanks for the reviews. I'll fiix Util.java and hold off integrating until tomorrow. - PR Comment: https

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio

2024-11-20 Thread Naoto Sato
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote: > Remove some occurrences of `GetPropertyAction` overlooked in #22219 and > #22132. Changes in `java.io.Console` and `sun.nio.cs.GB18030` look good. src/java.base/share/classes/sun/nio/fs/Util.java line 40: > 38: > 39: private sta

Re: RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio

2024-11-20 Thread Lance Andersen
On Wed, 20 Nov 2024 22:36:12 GMT, Brian Burkhalter wrote: > Remove some occurrences of `GetPropertyAction` overlooked in #22219 and > #22132. LGTM - Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22285#pullrequestreview-2449890758

RFR: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio

2024-11-20 Thread Brian Burkhalter
Remove some occurrences of `GetPropertyAction` overlooked in #22219 and #22132. - Commit messages: - 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio Changes: https://git.openjdk.org/jdk/pull/22285/files Webrev: https://webrevs.openjdk.org/?repo=